search

DuneSt / MaterialDesignLite

This project prime goal is to bind the google's Material Design Lite project to Seaside and as second goal to build widgets on top of Material Design to help Seaside developers to create web applications with material design faster.
https://mdl.ferlicot.fr/
MIT License
40 stars 20 forks source link

Implementation of SequenceableCollection>>#groupsOf: causes errors #324

Open Gabriel-Darbord opened 1 year ago

Gabriel-Darbord commented 1 year ago

The extension implementation of SequenceableCollection>>#groupsOf: uses a collection made with self species new to hold groups, however this is problematic when the receiver doesn't support the add: message, such as subclasses of ArrayedCollection.

This method has since been defined in Spec. Also, I didn't find any sender in the current version of this repo.

Thus, I suggest deleting the method. Although, if there is still a use for it, relying on Spec will not make it backwards compatible with earlier Pharo versions. Instead, self species new should be replaced with OrderedCollection new.

jecisc commented 1 year ago

If the extension is not used in MDL I'll deprecate and remove it