MacBook Pro 15+: Wifi Support

aunali1 commented 5 years ago

Discussion and updates regarding Broadcom Wifi related support. Parent thread is #71.

Current Status:

NOTE: Firmware from macOS Catalina is currently known to fail to initialize with brcmfmac. Use firmware from a macOS Mojave or lower installation, otherwise you can find the necessary files in my up-to-date archive here: https://packages.aunali1.com/apple/wifi-fw/18G2022

[x] Firmware Loading
- [x] BCM4355 (MacbookAir8,y)
- [x] BCM4364 (MacbookPro15,x)
- [ ] BCM4377 (MacbookPro15,4+ [2019])
[x] Frequency Bands
- [x] 2.4 GHz
- [x] 5 GHz
[x] Security Protocols
- [x] WPA
- [x] WPA2

Unfortunately, due to the nature of how tightly linked .clmb files are to each model variant, generic distribution of firmware is currently impractical.

jhohisel commented 5 years ago

Hi everyone! I've been following this thread as I work on getting a USB SSD with linux that works on both of my Macs: MacBookAir8,2 (2019 MacBook Air) and iMac19,1 (2019 iMac). Fortunately the 2019 iMac does not contain a T2 chip, so things work fairly well out of the box.

I'm attempting to get WiFi working on both models. The iMac seems to have the same chipset as the MacBookPro15,x (BCM4364, codename Midway) but the MacBook Air has a BCM4355 chipset (codename Hawaii). I created and applied this patch (based on the work from @MCMrARM): https://github.com/jhohisel/macbookair8-2-linux/blob/master/brcmfmac.patch and copied the firmware from macOS.

However, the firmware fails to load (iMac):

[   20.314189] usbcore: registered new interface driver brcmfmac
[   20.330616] brcmfmac 0000:03:00.0: enabling device (0000 -> 0002)
[   20.439205] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3
[   23.374627] brcmfmac 0000:03:00.0: brcmf_pcie_download_fw_nvram: FW failed to initialize

MacBook Air fails with a slightly different error:

[   27.958248] brcmfmac 0000:02:00.0: enabling device (0000 -> 0002)
[   28.121706] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4355-pcie for chip BCM4355/12
[   28.126287] brcmfmac 0000:02:00.0: Direct firmware load for brcm/brcmfmac4355-pcie.Apple Inc.-MacBookAir8,2.txt failed with error -2
[   31.030139] brcmfmac 0000:02:00.0: brcmf_pcie_download_fw_nvram: FW failed to initialize

I observe a different error when the NVRAM file (.txt) is missing, so I know that it is correctly detecting the presence of these files and attempting to load them.

Top tip: you can discover the firmware filenames that Apple uses by running: ioreg -l | grep RequestedFiles The output will look something like:

"RequestedFiles" = ({"Firmware"="C-4364__s-B2/midway.trx","TxCap"="C-4364__s-B2/midway-X0.txcb","Regulatory"="C-4364__s-B2/midway-X0.clmb","NVRAM"="C-4364__s-B2/P-midway-X0_M-HRPN_V-u__m-7.5.txt"})

ppaulweber commented 5 years ago

Top tip: you can discover the firmware filenames that Apple uses by running: ioreg -l | grep RequestedFiles

@jhohisel well done and nice tip!

I'm experimenting with the WLAN (WiFi) support on my MacBookAir8,1 since a week or so, I've pushed my version of this patch now as well (see reference above). Can you check if your MacBookAir8,2 platform goes along fine with the provided bcm5974, hid, nvme, and brcmfmac patches in https://github.com/ppaulweber/linux-mba? Thx!

jhohisel commented 5 years ago

I am currently running your bcm5974 and hid patches. Applying them added two-finger scrolling, right-click and function key support.

I'll try the nvme patch now.

jhohisel commented 5 years ago

bluehax@bluehax:~$ lsblk
NAME           MAJ:MIN RM   SIZE RO TYPE  MOUNTPOINT
sda              8:0    0 465.8G  0 disk  
├─sda1           8:1    0   448M  0 part  /boot/efi
├─sda2           8:2    0   4.7G  0 part  /media/bluehax/Debian Linux
├─sda3           8:3    0   4.7G  0 part  /boot
└─sda4           8:4    0   456G  0 part  
  └─sdb4_crypt 254:0    0   456G  0 crypt /
nvme0n1        259:0    0   113G  0 disk  
├─nvme0n1p1    259:1    0   300M  0 part  
└─nvme0n1p2    259:2    0 112.7G  0 part

NVMe Works! I'll have to try installing it to a partition on the laptop now.

One issue I've been unable to fix is getting the keyboard working when I unlock my root partition during boot. It works during the GRUB menu, then stops working when the kernel prompts to unlock the drive for dm-crypt, then functions immediately after when it loads the bce module.

I built-in mbp2018-bridge-drv to the kernel by adding a Kconfig entry and declaring the source to the Makefile in drivers/. Applied the patches for bcm5974 and hid, then set the module load order in /etc/modules-load.d/bce.conf.

ppaulweber commented 5 years ago

One issue I've been unable to fix is getting the keyboard working when I unlock my root partition during boot. It works during the GRUB menu, then stops working when the kernel prompts to unlock the drive for dm-crypt, then functions immediately after when it loads the bce module.

If you really need the keyboard in this case you have to take a look into your current /etc/mkinitcpio.conf setup. You shall include there the bce in the MODULE=... variable in order that the bce module even gets loaded and integrated into the initramfs creation.

Dunedan commented 5 years ago

Please focus on wifi in this issue and discuss other topics (like keyboard or NVMe) in separate issues.

mikeeq commented 5 years ago

Is WiFi (brcmfmac4364) working for anybody (besides @MCMrARM)?

Whenever i'm trying to load brcmfmac module, i'm getting error mentioned below:

[  990.003990] usbcore: registered new interface driver brcmfmac
[  990.110113] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3
[  992.693631] brcmfmac 0000:01:00.0: brcmf_pcie_download_fw_nvram: FW failed to initialize

aunali1 commented 5 years ago

@mikeeq What kernel patch are you using for WiFi support?

aunali1 commented 5 years ago

@jhohisel @mikeeq Works perfectly fine for me:

[    8.196831] usbcore: registered new interface driver brcmfmac
[    8.212808] brcmfmac 0000:03:00.0: enabling device (0000 -> 0002)
[    8.319800] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3
[    9.521164] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3
[    9.840308] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4364/3 wl0: Mar 28 2019 19:17:52 version 9.137.9.0.32.6.34 FWID 01-36f56c94
[    9.933835] brcmfmac 0000:03:00.0 wlp3s0: renamed from wlan0

EDIT: I'm using this wifi patch (in my kernel tree) btw.

mikeeq commented 5 years ago

@aunali1 yep, you're right - I've missed one line when I was generating a patch. https://github.com/mikeeq/mbp-fedora-kernel/commit/d8f5578d4fd9c9ee01c2a125dae30237aefcf391

@ppaulweber could you confirm if that fix is not needed for MacBookAir8,2?

ppaulweber commented 5 years ago

@aunali1 thanks for the hint and I've experimented for my MacBookAir8,1 that this brcm driver uses the same RAM base as the brcm driver of the MacBookPro15,x. It now allocates and loads correctly the firmware, and I get the wlan interface.

@jhohisel can you check if this latest patch works for your MacBookAir8,2 as well, thx!

@mikeeq it does need the same fix, which I've already updated in my repo (see commit reference above)

[  702.402953] usbcore: registered new interface driver brcmfmac
[  702.512262] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4355-pcie for chip BCM4355/12
[  702.960842] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4355-pcie for chip BCM4355/12
[  702.981704] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4355/12 wl0: Mar 28 2019 19:57:32 version 9.137.9.0.32.6.33 FWID 01-c5e1774f
[  703.109625] brcmfmac 0000:02:00.0 wlp2s0: renamed from wlan0

jhohisel commented 5 years ago

@ppaulweber The good news is that now the card is correctly recognized and shows as a WIFI device. The bad news is that I can't seem to connect to my network using it. It repeatedly times out and prompts for the password. I tried switching from wpa_supplicant to iwd as suggested in issue 71, but no difference. I also tried using wicd instead of NetworkManager, it fails to connect saying bad password. I have not yet tried an open network, and yes I am entering the correct password.

Has anyone else experienced this?

I am able to connect to my network using a USB WIFI card.

mikeeq commented 5 years ago

@jhohisel try to reload brcmfmac kernel module. I'm experiencing the same issue and after module reload I'm able to connect to WPA2 network ;)

https://github.com/mikeeq/mbp-fedora#known-issues

ppaulweber commented 5 years ago

@jhohisel I can confirm that for me is wpa_supplicantno longer working as well. With iwdthe WLAN (WiFi) is working as expected. Thx @mikeeq for collecting the known issues in your repo!

jhohisel commented 5 years ago

I was missing:

[device]
wifi.backend=iwd

From /etc/NetworkManager/NetworkManager.conf

Now I can connect!

macphotoed commented 5 years ago

Sorry for the silly question all - when I locate the files from mojave, where do I copy them on the linux side?

aunali1 commented 5 years ago

@macphotoed Just copy the .trx file to /lib/firmware/brcm/brcmfmac4364-pcie.trx, the .clmb file to /lib/firmware/brcm/brcmfmac4364-pcie.clm_blob and the *.txt file to /lib/firmware/brcm/brcmfmac4364-pcie.Apple Inc.-MacBookPro15,1.txt

macphotoed commented 5 years ago

Amazing - thank you again @aunali1 - got the files, tjust grappling with the iwd/wpa_supplicant issue! And bluetooth for some reason?

MCMrARM commented 5 years ago

By the way 5Ghz generally works for me, through a full multiband 5ac does not achieve full speeds.

wzygzlm commented 5 years ago

Sorry. I'd like to ask if I don't have IDA，how can I get the wifi firmware? Do anybody can share one with me. Mine model is mbp2010 13inch.

MCMrARM notifications@github.com于2019年8月28日周三21:55写道：

By the way 5Ghz generally works for me, through a full multiband 5ac does not achieve full speeds.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Dunedan/mbp-2016-linux/issues/112?email_source=notifications&email_token=AB7YLWSIKQQMJHPGUGE7ELTQG3J3NA5CNFSM4IJYB3TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MJBLQ#issuecomment-525897902, or mute the thread https://github.com/notifications/unsubscribe-auth/AB7YLWVD7Z2O5KIWNKGTKKDQG3J3NANCNFSM4IJYB3TA .

-- Best Regards, Liu, Min INI, UZH/ETHZ

aunali1 commented 5 years ago

It seems that with 5.2.11, 5 Ghz works without any problems, and in some cases faster than macOS!

MCMrARM commented 5 years ago

@wzygzlm I mean, this no longer requires IDA, the firmware is in /usr/share/firmware on OS X.

TRPB commented 5 years ago

can anyone tell me where the trx and clmb files are? On Arch if it makes any difference.

MCMrARM commented 5 years ago

TL;Dr with the wifi is to first find your firmware files using ioreg -l | grep C-4364, then copy them from /usr/share/firmware/wifi from OS X. On Linux, the .trx file for your model goes to /lib/firmware/brcm/brcmfmac4364-pcie.bin, the .clmb goes to /lib/firmware/brcm/brcmfmac4364-pcie.clm_blob and the .txt to something like /lib/firmware/brcm/brcmfmac4364-pcie.Apple Inc.-MacBookPro15,2.txt All of this requires a kernel patch: https://mrarm.io/u/Paste%202019-07-26%2012-30-16.txt

0xEmma commented 5 years ago

Anyone else not have this working on MBA 8,1(air 2018) it shows up as a ethernet device, thanks :)

MCMrARM commented 5 years ago

@EmmaDSamms sorry, what? Show the output of lspci?

caioquirino commented 5 years ago

Hi people, for me I have the files in /lib/firmware/brcm/ exactly as @MCMrARM mentioned but when I run modprobe brcm80211 either in boot time or after, my arch-linux just freeze completely. How can I investigate it? because it just hangs and I need to reboot... If I remove the files, it just starts normally but without wifi working (as expected)

loafbox commented 5 years ago

So I've completely uninstalled MacOS and think I copied over the wrong firmware files before wiping it out. Would anyone happen to have firmware files for MacBookPro15,x T2 touchbar model?
Need...

"Firmware"="C-4364__s-B2/kauai.trx"
"imagename"="C-4364__s-B2/kauai-X0.clmb"
"NVRAM"="C-4364__s-B2/P-kauai-X0_M-HRPN_V-u__m-7.5.txt"

MCMrARM commented 5 years ago

I'd suggest against uninstalling MacOS completely because of MacOS being your best firmware update source, so you should keep it if you want to say, update bridgeOS.

mkexc commented 5 years ago

Is it possible to apply this procedure to MBP 13,3? Taking the .trx, .clmb and .txt from osx and putting them in linux?

cubimon commented 4 years ago

I can't get it working on my MBP 2019 15,1. I installed iwd, NetworkManager, enabled the services iwd and NetworkManager, set iwd as default wifi backend in /etc/NetworkManager/NetworkManager.conf, copied the three files from OSX to proper names in /lib/firmware/brcm/. I have aunali1's linux mbp kernel which contains the wifi patches. What am I missing? dmesg says this after boot:

[    4.446767] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3
[    4.479882] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4364/3 wl0: Mar 28 2019 19:17:52 version 9.137.9.0.32.6.34 FWID 01-36f56c94
[    4.498323] ieee80211 phy0: brcmf_cfg80211_add_iface: iface validation failed: err=-16

~~When I run sudo modprobe -r brcmfmac; sudo modprobe brcmfmac, I see~~

[ 1137.569122] ieee80211 phy0: brcmf_fil_cmd_data: bus is down. we have nothing to do.
[ 1137.569355] ieee80211 phy0: brcmf_fil_cmd_data: bus is down. we have nothing to do.
[ 1137.569359] ieee80211 phy0: brcmf_cfg80211_get_channel: chanspec failed (-5)

~~And a bit later~~

[ 1138.193219] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3
[ 1139.068592] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3
[ 1139.098725] brcmfmac: brcmf_c_preinit_dcmds: Firmware: BCM4364/3 wl0: Mar 28 2019 19:17:52 version 9.137.9.0.32.6.34 FWID 01-36f56c94

~~But I stilll can't use it. So am I too stupid to use the wifi device or idk. ip addr shows this:~~

4: wlan0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc fq_codel state DOWN group default qlen 1000
    link/ether ${macaddress} ff:ff:ff:ff:ff:ff

Edit: I guess I was missing the bridge/bce module, not 100% sure though

geovie commented 4 years ago

After following @MCMrARM's guide to copy the WIFI firmware files I get the following error when the firmware files are loaded (dmesg | grep brcm output):

usbcore: registered new interface driver brcmfmac  
brcmfmac 0000:01:00.0: enabling device (0000 -> 0002)  
brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3  
bluetooth hci0: Direct firmware load for brcm/BCM.hcd failed with error -2  
Bluetooth: hci0: BCM: Patch brcm/BCM.hcd not found  
brcmfmac 0000:01:00.0: brcmf_pcie_download_fw_nvram: FW failed to initialize

More information here: https://github.com/mikeeq/mbp-fedora-kernel/issues/1 Has anyone an idea why it's failing to initialize?

TIA

Xinkai commented 4 years ago

I am having the same issue @geovie. This is the dmesg with brcmfmac.debug=2097150. (Some omitted).

Kernel: https://github.com/aunali1/linux-mbp-arch @ 5.4.6

[    4.055976] brcmfmac: brcmfmac_module_init No platform data available.
[    4.055988] brcmfmac: brcmf_usb_register Enter
[    4.056000] usbcore: registered new interface driver brcmfmac
[    4.056000] brcmfmac: brcmf_pcie_register Enter
[    4.056024] brcmfmac: brcmf_pcie_probe Enter 14e4:4464
[    4.056135] brcmfmac 0000:05:00.0: enabling device (0000 -> 0002)
[    4.056320] brcmfmac: brcmf_pcie_get_resource Phys addr : reg space = 000000009656594a base addr 0x00000081400000
[    4.056321] brcmfmac: brcmf_pcie_get_resource Phys addr : mem space = 000000001afaff3b base addr 0x00000081000000 size 0x400000
[    4.056440] brcmfmac: brcmf_chip_recognition found AXI chip: BCM4364/3
[    4.062520] brcmfmac: brcmf_chip_cores_check  [1 ] core 0x800:59 base 0x18000000 wrap 0x18100000
[    4.062522] brcmfmac: brcmf_chip_cores_check  [2 ] core 0x812:58 base 0x18001000 wrap 0x18101000
[    4.062522] brcmfmac: brcmf_chip_cores_check  [3 ] core 0x83e:12 base 0x18002000 wrap 0x18102000
[    4.062523] brcmfmac: brcmf_chip_cores_check  [4 ] core 0x83c:16 base 0x18003000 wrap 0x18103000
[    4.062523] brcmfmac: brcmf_chip_cores_check  [5 ] core 0x812:58 base 0x18004000 wrap 0x18104000
[    4.062524] brcmfmac: brcmf_chip_cores_check  [6 ] core 0x829:22 base 0x18005000 wrap 0x18105000
[    4.062525] brcmfmac: brcmf_chip_cores_check  [7 ] core 0x840:7  base 0x1800a000 wrap 0x00000000
[    4.062525] brcmfmac: brcmf_chip_cores_check  [8 ] core 0x135:0  base 0x00000000 wrap 0x18108000
[    4.062526] brcmfmac: brcmf_chip_cores_check  [9 ] core 0x240:0  base 0x00000000 wrap 0x00000000
[    4.062526] brcmfmac: brcmf_chip_set_passive Enter
[    4.169825] brcmfmac: brcmf_chip_set_passive Enter
[    4.170427] brcmfmac: brcmf_chip_get_raminfo RAM: base=0x160000 size=1310720 (0x140000) sr=0 (0x0)
[    4.170439] brcmfmac: brcmf_chip_setup ccrev=59, pmurev=29, pmucaps=0x3c8c3f1d
[    4.170440] brcmfmac: brcmf_get_module_param Enter, bus=2, chip=17252, rev=3
[    4.170444] brcmfmac: brcmf_alloc Enter
[    4.170451] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4364-pcie for chip BCM4364/3
[    4.173974] brcmfmac: brcmf_fw_get_firmwares enter: dev=0000:05:00.0
[    4.175877] brcmfmac: brcmf_fw_complete_request firmware brcm/brcmfmac4364-pcie.bin found
[    4.176362] brcmfmac: brcmf_fw_complete_request firmware brcm/brcmfmac4364-pcie.txt found
[    4.176364] brcmfmac: brcmf_fw_request_nvram_done enter: dev=0000:05:00.0
[    4.176490] brcmfmac: brcmf_fw_request_nvram_done nvram 000000009a836282 len 12896
[    4.176812] brcmfmac: brcmf_chip_get_raminfo RAM: base=0x160000 size=1310720 (0x140000) sr=0 (0x0)
[    4.176813] brcmfmac: brcmf_pcie_download_fw_nvram Halt ARM.
[    4.176814] brcmfmac: brcmf_pcie_download_fw_nvram Download FW brcm/brcmfmac4364-pcie.bin
[    4.466551] brcmfmac: brcmf_pcie_download_fw_nvram Download NVRAM brcm/brcmfmac4364-pcie.txt
[    4.468466] brcmfmac: brcmf_pcie_download_fw_nvram Bring ARM in running state
[    4.468467] brcmfmac: brcmf_chip_set_active Enter
[    4.468810] brcmfmac: brcmf_pcie_download_fw_nvram Wait for FW init
[    6.740083] brcmfmac 0000:05:00.0: brcmf_pcie_download_fw_nvram: FW failed to initialize
[    6.747010] brcmfmac: brcmf_pcie_remove Enter
[    6.747011] brcmfmac: brcmf_detach Enter
[    6.760007] brcmfmac: brcmf_bus_change_state 0 -> 0
[    6.760013] ------------[ cut here ]------------
[    6.760018] WARNING: CPU: 8 PID: 241 at kernel/workqueue.c:3037 __flush_work+0x1c8/0x1e0
[    6.760019] Modules linked in: input_leds hid_apple apple_ib_als(OE) industrialio_triggered_buffer kfifo_buf industrialio apple_ib_tb(OE) apple_ibridge(OE) uvcvideo videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 hid_generic cdc_mbim mousedev videobuf2_common cdc_wdm videodev cdc_ncm usbnet usbhid hid mc mii cmac algif_hash algif_skcipher af_alg intel_rapl_msr intel_rapl_common bnep x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul msr ghash_clmulni_intel brcmfmac brcmutil nls_iso8859_1 nls_cp437 snd_hda_codec_hdmi aesni_intel vfat fat snd_hda_intel crypto_simd cfg80211 mei_hdcp hci_uart snd_intel_nhlt 8250_dw cryptd glue_helper intel_cstate btqca intel_uncore btrtl iTCO_wdt btbcm iTCO_vendor_support btintel mei_me bluetooth intel_lpss_pci mmc_core snd_hda_codec intel_rapl_perf mei i2c_i801 pcspkr intel_lpss idma64 snd_hda_core intel_pch_thermal snd_hwdep ecdh_generic sbs rfkill apple_gmux ecc sbshc acpi_tad apple_bl evdev mac_hid
[    6.760049]  ac pkcs8_key_parser crypto_user apple_bce(OE) snd_pcm snd_timer snd soundcore ip_tables x_tables btrfs libcrc32c crc32c_generic xor raid6_pq xhci_pci crc32c_intel xhci_hcd amdgpu gpu_sched i2c_algo_bit ttm drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm agpgart
[    6.760062] CPU: 8 PID: 241 Comm: kworker/8:1 Tainted: G           OE     5.4.6-1-mbp #1
[    6.760063] Hardware name: Apple Inc. MacBookPro15,3/Mac-1E7E29AD0135F9BC, BIOS 1037.60.58.0.0 (iBridge: 17.16.12551.0.0,0) 11/14/2019
[    6.760065] Workqueue: events request_firmware_work_func
[    6.760067] RIP: 0010:__flush_work+0x1c8/0x1e0
[    6.760069] Code: 8a 88 00 e8 fa 40 06 00 45 31 f6 eb 85 8b 0b 48 8b 53 08 83 e1 08 48 0f ba 2b 03 80 c9 f0 e9 4d ff ff ff 0f 0b e9 68 ff ff ff <0f> 0b 45 31 f6 e9 5e ff ff ff e8 e9 03 fe ff 66 0f 1f 84 00 00 00
[    6.760070] RSP: 0018:ffffad64c05cbbe0 EFLAGS: 00010246
[    6.760071] RAX: 0000000000000000 RBX: ffff8c6e41f0e948 RCX: 0000000000000000
[    6.760072] RDX: 0000000000000001 RSI: 0000000000000001 RDI: ffffad64c05cbc28
[    6.760072] RBP: 0000000000000000 R08: 0000000000000648 R09: 0000000000000004
[    6.760073] R10: 0000000000000000 R11: 0000000000000001 R12: ffff8c6e41f0e948
[    6.760073] R13: ffffad64c05cbbe0 R14: 0000000000000001 R15: 0000000000000000
[    6.760074] FS:  0000000000000000(0000) GS:ffff8c6e5ea00000(0000) knlGS:0000000000000000
[    6.760075] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    6.760076] CR2: 0000556b3658bae8 CR3: 00000004fac0a001 CR4: 00000000003606e0
[    6.760077] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[    6.760078] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[    6.760078] Call Trace:
[    6.760083]  __cancel_work_timer+0x123/0x1b0
[    6.760094]  brcmf_fweh_detach+0x15/0x60 [brcmfmac]
[    6.760103]  brcmf_detach+0x80/0xd0 [brcmfmac]
[    6.760113]  brcmf_pcie_remove+0x70/0x110 [brcmfmac]
[    6.760115]  pci_device_remove+0x3b/0xa0
[    6.760118]  device_release_driver_internal+0xe4/0x1c0
[    6.760128]  brcmf_pcie_setup+0x38/0xd90 [brcmfmac]
[    6.760137]  brcmf_fw_request_done+0x65/0xe0 [brcmfmac]
[    6.760139]  request_firmware_work_func+0x4f/0x8d
[    6.760141]  process_one_work+0x1e2/0x3b0
[    6.760143]  worker_thread+0x4a/0x3d0
[    6.760145]  kthread+0xfb/0x130
[    6.760147]  ? process_one_work+0x3b0/0x3b0
[    6.760148]  ? kthread_park+0x90/0x90
[    6.760150]  ret_from_fork+0x1f/0x40
[    6.760153] ---[ end trace 83d738c81ce04d69 ]---
[    6.760165] ------------[ cut here ]------------
[    6.760173] WARNING: CPU: 8 PID: 241 at drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:309 brcmf_fweh_detach+0x5b/0x60 [brcmfmac]
[    6.760173] Modules linked in: input_leds hid_apple apple_ib_als(OE) industrialio_triggered_buffer kfifo_buf industrialio apple_ib_tb(OE) apple_ibridge(OE) uvcvideo videobuf2_vmalloc videobuf2_memops joydev videobuf2_v4l2 hid_generic cdc_mbim mousedev videobuf2_common cdc_wdm videodev cdc_ncm usbnet usbhid hid mc mii cmac algif_hash algif_skcipher af_alg intel_rapl_msr intel_rapl_common bnep x86_pkg_temp_thermal intel_powerclamp coretemp kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul msr ghash_clmulni_intel brcmfmac brcmutil nls_iso8859_1 nls_cp437 snd_hda_codec_hdmi aesni_intel vfat fat snd_hda_intel crypto_simd cfg80211 mei_hdcp hci_uart snd_intel_nhlt 8250_dw cryptd glue_helper intel_cstate btqca intel_uncore btrtl iTCO_wdt btbcm iTCO_vendor_support btintel mei_me bluetooth intel_lpss_pci mmc_core snd_hda_codec intel_rapl_perf mei i2c_i801 pcspkr intel_lpss idma64 snd_hda_core intel_pch_thermal snd_hwdep ecdh_generic sbs rfkill apple_gmux ecc sbshc acpi_tad apple_bl evdev mac_hid
[    6.760191]  ac pkcs8_key_parser crypto_user apple_bce(OE) snd_pcm snd_timer snd soundcore ip_tables x_tables btrfs libcrc32c crc32c_generic xor raid6_pq xhci_pci crc32c_intel xhci_hcd amdgpu gpu_sched i2c_algo_bit ttm drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm agpgart
[    6.760198] CPU: 8 PID: 241 Comm: kworker/8:1 Tainted: G        W  OE     5.4.6-1-mbp #1
[    6.760198] Hardware name: Apple Inc. MacBookPro15,3/Mac-1E7E29AD0135F9BC, BIOS 1037.60.58.0.0 (iBridge: 17.16.12551.0.0,0) 11/14/2019
[    6.760200] Workqueue: events request_firmware_work_func
[    6.760208] RIP: 0010:brcmf_fweh_detach+0x5b/0x60 [brcmfmac]
[    6.760209] Code: 48 c7 83 e0 21 00 00 00 00 00 00 48 c7 83 30 26 00 00 00 00 00 00 48 83 e7 f8 29 fb 8d 8b 38 26 00 00 c1 e9 03 f3 48 ab 5b c3 <0f> 0b eb c9 90 0f 1f 44 00 00 89 f0 48 8d 04 c7 48 83 b8 e0 21 00
[    6.760210] RSP: 0018:ffffad64c05cbcd8 EFLAGS: 00010282
[    6.760211] RAX: 0000000000000000 RBX: ffff8c6e41f0c7a0 RCX: 0000000000000000
[    6.760211] RDX: ffff8c6e41f0e970 RSI: 0000000000000001 RDI: ffffad64c05cbc28
[    6.760212] RBP: ffff8c6e41f0c7a0 R08: 0000000000000648 R09: 0000000000000004
[    6.760212] R10: 0000000000000000 R11: 0000000000000001 R12: ffff8c6e41f0c850
[    6.760213] R13: ffff8c6e598310b0 R14: 00000000f3680c97 R15: 0000000000000000
[    6.760214] FS:  0000000000000000(0000) GS:ffff8c6e5ea00000(0000) knlGS:0000000000000000
[    6.760215] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[    6.760216] CR2: 0000556b3658bae8 CR3: 00000004fac0a001 CR4: 00000000003606e0
[    6.760216] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[    6.760217] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[    6.760217] Call Trace:
[    6.760225]  brcmf_detach+0x80/0xd0 [brcmfmac]
[    6.760234]  brcmf_pcie_remove+0x70/0x110 [brcmfmac]
[    6.760236]  pci_device_remove+0x3b/0xa0
[    6.760238]  device_release_driver_internal+0xe4/0x1c0
[    6.760246]  brcmf_pcie_setup+0x38/0xd90 [brcmfmac]
[    6.760255]  brcmf_fw_request_done+0x65/0xe0 [brcmfmac]
[    6.760257]  request_firmware_work_func+0x4f/0x8d
[    6.760259]  process_one_work+0x1e2/0x3b0
[    6.760261]  worker_thread+0x4a/0x3d0
[    6.760263]  kthread+0xfb/0x130
[    6.760264]  ? process_one_work+0x3b0/0x3b0
[    6.760265]  ? kthread_park+0x90/0x90
[    6.760267]  ret_from_fork+0x1f/0x40
[    6.760269] ---[ end trace 83d738c81ce04d6a ]---
[    6.760271] brcmfmac: brcmf_proto_detach Enter

Xinkai commented 4 years ago

From what I understand, the firmware is executed not on the CPU but on the Wifi device. Is there a way to make the Broadcom chip talk back so we can know what's going on? I noticed that there's a fwsignal.c file in the kernel tree that suggests it kinda does that, but I don't know how to use it.

Let me know if any more information is needed.

yurnam commented 4 years ago

similar issue with mbp 15,4 it uses a BCM4377 with a device id: 4488 coultn't find anything about it. attempted to implement it like in https://mrarm.io/u/Paste%202019-07-26%2012-30-16.txt but with 4488 instead of 4464 & 4377 instead of 4364, copied the trx, clmb, and txt, from macOS but when i load the brcmfmac module this happens:

on macOS:

$ ioreg -l | grep RequestedFiles
"RequestedFiles" = ({"Firmware"="C-4377__s-B3/formosa.trx","TxCap"="C-4377__s-B3/formosa-X3.txcb","Regulatory"="C-4377__s-B3/formosa-X3.clmb","NVRAM"="C-4377__s-B3/P-formosa-X3_M-SPPR_V-u__m-3.1.txt"})

on linux 5.4.6:

# modprobe brcmfmac
[24.xxxxx] brcmfmac: brcmf_fw_alloc_request: using brcmfmac4377-pcie for chip 4377/4
[26.xxxxx] brcmfmac: 0000:01:00.0 brcmf_pcie_download_nvram: Invalid shared RAM address 0xfffffff

then my mac freezes and after a few seconds it restarts. this only happens when i have the brcmfmac4377-pcie* files in /lib/firmware/brcm otherwise it obviously just exits with cant find the files.

output of lspci shows 2 Broadcom network controllers:

00:00.0 Host bridge: Intel Corporation 8th Gen Core Processor Host Bridge/DRAM Registers (rev 08)
00:02.0 VGA compatible controller: Intel Corporation Device 3ea6 (rev 01)
00:12.0 Signal processing controller: Intel Corporation Cannon Point-LP Thermal Controller (rev 30)
00:14.0 USB controller: Intel Corporation Cannon Point-LP USB 3.1 xHCI Controller (rev 30)
00:14.2 RAM memory: Intel Corporation Cannon Point-LP Shared SRAM (rev 30)
00:16.0 Communication controller: Intel Corporation Cannon Point-LP MEI Controller #1 (rev 30)
00:1c.0 PCI bridge: Intel Corporation Device 9dba (rev f0)
00:1c.4 PCI bridge: Intel Corporation Cannon Point-LP PCI Express Root Port #5 (rev f0)
00:1d.0 PCI bridge: Intel Corporation Cannon Point-LP PCI Express Root Port #13 (rev f0)
00:1e.0 Communication controller: Intel Corporation Device 9da8 (rev 30)
00:1f.0 ISA bridge: Intel Corporation Cannon Point-LP LPC Controller (rev 30)
00:1f.3 Audio device: Intel Corporation Cannon Point-LP High Definition Audio Controller (rev 30)
00:1f.4 SMBus: Intel Corporation Cannon Point-LP SMBus Controller (rev 30)
00:1f.5 Serial bus controller [0c80]: Intel Corporation Cannon Point-LP SPI Controller (rev 30)
01:00.0 Network controller: Broadcom Inc. and subsidiaries Device 4488 (rev 04)
01:00.1 Network controller: Broadcom Inc. and subsidiaries Device 5fa0 (rev 04)
02:00.0 Mass storage controller: Apple Inc. ANS2 NVMe Controller (rev 01)
02:00.1 Non-VGA unclassified device: Apple Inc. T2 Bridge Controller (rev 01)
02:00.2 Non-VGA unclassified device: Apple Inc. T2 Secure Enclave Processor (rev 01)
02:00.3 Multimedia audio controller: Apple Inc. Apple Audio Device (rev 01)
03:00.0 PCI bridge: Intel Corporation JHL7540 Thunderbolt 3 Bridge [Titan Ridge 4C 2018] (rev 06)
04:00.0 PCI bridge: Intel Corporation JHL7540 Thunderbolt 3 Bridge [Titan Ridge 4C 2018] (rev 06)
04:01.0 PCI bridge: Intel Corporation JHL7540 Thunderbolt 3 Bridge [Titan Ridge 4C 2018] (rev 06)
04:02.0 PCI bridge: Intel Corporation JHL7540 Thunderbolt 3 Bridge [Titan Ridge 4C 2018] (rev 06)
04:04.0 PCI bridge: Intel Corporation JHL7540 Thunderbolt 3 Bridge [Titan Ridge 4C 2018] (rev 06)
05:00.0 System peripheral: Intel Corporation JHL7540 Thunderbolt 3 NHI [Titan Ridge 4C 2018] (rev 06)
06:00.0 USB controller: Intel Corporation JHL7540 Thunderbolt 3 USB Controller [Titan Ridge 4C 2018] (rev 06)

would be nice if anyone could help me :)

aunali1 commented 4 years ago

@yurnam The patch that you are basing your changes on is incomplete as it does not include the rambase address diff.

Since this a new chip variant, we can potentially determine the rambase by enabling some more debug info. Please post the dmesg output with the additional kernel argument brcmfmac.debug=2097150. I'm particularly interested in the line containing brcmf_chip_get_raminfo.

Can you also clone this repo and runget-info.sh and PR the results. the 15,4 variant seems to differ quite a bit AFAI can tell.

yurnam commented 4 years ago

oh sorry, I was using the patch which includes the rambase address 0x160000 i used this address also for the 4377 chip, which was probably a bad idea. if i change or remove it, the mac doesnt freeze anymore.

anyway i made a PR to your repo with the mbp15,4 dumps thank you!

EDIT:

# dmesg | grep brcmf
[    0.000000] Command line: BOOT_IMAGE=/boot/vmlinuz-5.5.0-rc4 root=UUID=967cef72-c47e-4565-9c41-92ef1ac054da ro quiet splash brcmfmac.debug=2097150
[    0.115316] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-5.5.0-rc4 root=UUID=967cef72-c47e-4565-9c41-92ef1ac054da ro quiet splash brcmfmac.debug=2097150
[   34.604791] brcmfmac: brcmfmac_module_init No platform data available.
[   34.604797] brcmfmac: brcmf_pcie_register Enter
[   34.604817] brcmfmac: brcmf_pcie_probe Enter 14e4:4488
[   34.619461] brcmfmac 0000:01:00.0: enabling device (0000 -> 0002)
[   34.619646] brcmfmac: brcmf_pcie_get_resource Phys addr : reg space = 00000000f51725ac base addr 0x00000091800000
[   34.619647] brcmfmac: brcmf_pcie_get_resource Phys addr : mem space = 0000000046ec6721 base addr 0x00000091000000 size 0x400000
[   34.619755] brcmfmac: brcmf_chip_recognition found AXI chip: BCM4377/4
[   34.620125] brcmfmac: brcmf_chip_cores_check  [1 ] core 0x800:64 base 0x18000000 wrap 0x18100000
[   34.620126] brcmfmac: brcmf_chip_cores_check  [2 ] core 0x812:82 base 0x18001000 wrap 0x18101000
[   34.620127] brcmfmac: brcmf_chip_cores_check  [3 ] core 0x83e:15 base 0x18002000 wrap 0x18102000
[   34.620127] brcmfmac: brcmf_chip_cores_check  [4 ] core 0x83c:64 base 0x18003000 wrap 0x18103000
[   34.620128] brcmfmac: brcmf_chip_cores_check  [5 ] core 0x812:82 base 0x18004000 wrap 0x18104000
[   34.620128] brcmfmac: brcmf_chip_cores_check  [6 ] core 0x844:2  base 0x18005000 wrap 0x18105000
[   34.620129] brcmfmac: brcmf_chip_cores_check  [7 ] core 0x840:15 base 0x18010000 wrap 0x00000000
[   34.620130] brcmfmac: brcmf_chip_cores_check  [8 ] core 0x827:35 base 0x18012000 wrap 0x00000000
[   34.620130] brcmfmac: brcmf_chip_cores_check  [9 ] core 0x240:0  base 0x00000000 wrap 0x1810c000
[   34.620131] brcmfmac: brcmf_chip_cores_check  [10] core 0x135:0  base 0x00000000 wrap 0x18112000
[   34.620131] brcmfmac: brcmf_chip_cores_check  [11] core 0x135:0  base 0x00000000 wrap 0x18113000
[   34.620132] brcmfmac: brcmf_chip_set_passive Enter
[   34.725973] brcmfmac: brcmf_chip_set_passive Enter
[   34.726751] brcmfmac: brcmf_chip_tcm_rambase: unknown chip: BCM4377/4
[   34.726870] brcmfmac: brcmf_chip_get_raminfo: RAM base not provided with ARM CR4 core
[   34.726996] brcmfmac: brcmf_pcie_probe: failed 14e4:4488
[   34.727401] brcmfmac: probe of 0000:01:00.0 failed with error -22

aunali1 commented 4 years ago

@yurnam Hmm, it seems that the rambase address needs to be found through trial and error. Can you please test through the rambase addresses in this switch case (0x160000 is already known not to work).

yurnam commented 4 years ago

dmesg.txt tried all of them output looks always like this:

$ dmesg | grep brcmf

[    0.115781] Kernel command line: BOOT_IMAGE=/boot/vmlinuz-5.5.0-rc4 root=UUID=967cef72-c47e-4565-9c41-92ef1ac054da ro net.ifnames=0 biosdevname=0 quiet splash brcmfmac.debug=2097150
[  229.970017] brcmfmac: brcmfmac_module_init No platform data available.
[  229.970022] brcmfmac: brcmf_pcie_register Enter
[  229.970038] brcmfmac: brcmf_pcie_probe Enter 14e4:4488
[  229.986615] brcmfmac 0000:01:00.0: enabling device (0000 -> 0002)
[  229.986852] brcmfmac: brcmf_pcie_get_resource Phys addr : reg space = 00000000fbeb7416 base addr 0x00000091800000
[  229.986853] brcmfmac: brcmf_pcie_get_resource Phys addr : mem space = 000000004919b7a6 base addr 0x00000091000000 size 0x400000
[  229.986962] brcmfmac: brcmf_chip_recognition found AXI chip: BCM4377/4
[  229.987331] brcmfmac: brcmf_chip_cores_check  [1 ] core 0x800:64 base 0x18000000 wrap 0x18100000
[  229.987332] brcmfmac: brcmf_chip_cores_check  [2 ] core 0x812:82 base 0x18001000 wrap 0x18101000
[  229.987333] brcmfmac: brcmf_chip_cores_check  [3 ] core 0x83e:15 base 0x18002000 wrap 0x18102000
[  229.987334] brcmfmac: brcmf_chip_cores_check  [4 ] core 0x83c:64 base 0x18003000 wrap 0x18103000
[  229.987334] brcmfmac: brcmf_chip_cores_check  [5 ] core 0x812:82 base 0x18004000 wrap 0x18104000
[  229.987335] brcmfmac: brcmf_chip_cores_check  [6 ] core 0x844:2  base 0x18005000 wrap 0x18105000
[  229.987336] brcmfmac: brcmf_chip_cores_check  [7 ] core 0x840:15 base 0x18010000 wrap 0x00000000
[  229.987336] brcmfmac: brcmf_chip_cores_check  [8 ] core 0x827:35 base 0x18012000 wrap 0x00000000
[  229.987337] brcmfmac: brcmf_chip_cores_check  [9 ] core 0x240:0  base 0x00000000 wrap 0x1810c000
[  229.987338] brcmfmac: brcmf_chip_cores_check  [10] core 0x135:0  base 0x00000000 wrap 0x18112000
[  229.987338] brcmfmac: brcmf_chip_cores_check  [11] core 0x135:0  base 0x00000000 wrap 0x18113000
[  229.987339] brcmfmac: brcmf_chip_set_passive Enter
[  230.093188] brcmfmac: brcmf_chip_set_passive Enter
[  230.093773] brcmfmac: brcmf_chip_get_raminfo RAM: base=0x198000 size=1638400 (0x190000) sr=0 (0x0)
[  230.093784] brcmfmac: brcmf_chip_setup ccrev=64, pmurev=35, pmucaps=0x84565f23
[  230.093786] brcmfmac: brcmf_get_module_param Enter, bus=2, chip=17271, rev=4
[  230.093790] brcmfmac: brcmf_alloc Enter
[  230.093802] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4377-pcie for chip BCM4377/4
[  230.093807] brcmfmac: brcmf_fw_get_firmwares enter: dev=0000:01:00.0
[  230.096520] brcmfmac: brcmf_fw_complete_request firmware brcm/brcmfmac4377-pcie.bin found
[  230.097082] brcmfmac: brcmf_fw_complete_request firmware brcm/brcmfmac4377-pcie.txt found
[  230.097084] brcmfmac: brcmf_fw_request_nvram_done enter: dev=0000:01:00.0
[  230.097298] brcmfmac: brcmf_fw_request_nvram_done nvram 0000000021820ad9 len 4924
[  230.097457] brcmfmac: brcmf_chip_get_raminfo RAM: base=0x198000 size=1638400 (0x190000) sr=0 (0x0)
[  230.097458] brcmfmac: brcmf_pcie_download_fw_nvram Halt ARM.
[  230.097459] brcmfmac: brcmf_pcie_download_fw_nvram Download FW brcm/brcmfmac4377-pcie.bin
[  230.259368] brcmfmac: brcmf_pcie_download_fw_nvram Download NVRAM brcm/brcmfmac4377-pcie.txt
[  230.260366] brcmfmac: brcmf_pcie_download_fw_nvram Bring ARM in running state
[  230.260367] brcmfmac: brcmf_chip_set_active Enter
[  230.260566] brcmfmac: brcmf_pcie_download_fw_nvram Wait for FW init
[  232.533371] brcmfmac 0000:01:00.0: brcmf_pcie_download_fw_nvram: FW failed to initialize
[  232.533394] brcmfmac: brcmf_pcie_remove Enter
[  232.533397] brcmfmac: brcmf_detach Enter
[  232.560082] brcmfmac: brcmf_bus_change_state 0 -> 0
[  232.560111] Modules linked in: brcmfmac brcmutil sd_mod sg uas usb_storage scsi_mod r8188eu(C) lib80211 cfg80211 fuse hid_apple input_leds apple_ib_als(OE) industrialio_triggered_buffer kfifo_buf industrialio apple_ib_tb(OE) apple_ibridge(OE) joydev cdc_mbim cdc_wdm mousedev hid_generic uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common videodev cdc_ncm usbhid usbnet mc hid mii snd_hda_codec_hdmi squashfs rfkill loop intel_rapl_msr intel_rapl_common x86_pkg_temp_thermal intel_powerclamp coretemp snd_sof_pci kvm_intel snd_sof_intel_byt i915 snd_sof_intel_ipc kvm snd_sof_xtensa_dsp snd_sof_intel_hda_common snd_soc_hdac_hda irqbypass snd_sof_intel_hda snd_sof snd_hda_ext_core snd_soc_acpi_intel_match i2c_algo_bit crct10dif_pclmul snd_soc_acpi crc32_pclmul ledtrig_audio drm_kms_helper ghash_clmulni_intel snd_soc_core nls_iso8859_1 snd_compress aesni_intel nls_cp437 drm ac97_bus crypto_simd vfat snd_pcm_dmaengine fat cryptd glue_helper mei_hdcp intel_gtt intel_cstate
[  232.560329]  ? __brcmf_dbg+0x8b/0x110 [brcmfmac]
[  232.560362]  brcmf_fweh_detach+0x15/0x60 [brcmfmac]
[  232.560378]  brcmf_detach+0x72/0xf0 [brcmfmac]
[  232.560395]  brcmf_pcie_remove+0x70/0x110 [brcmfmac]
[  232.560426]  brcmf_pcie_setup+0x38/0xd70 [brcmfmac]
[  232.560446]  brcmf_fw_request_done+0x65/0xe0 [brcmfmac]
[  232.560555] WARNING: CPU: 7 PID: 182 at drivers/net/wireless/broadcom/brcm80211/brcmfmac/fweh.c:309 brcmf_fweh_detach+0x5b/0x60 [brcmfmac]
[  232.560556] Modules linked in: brcmfmac brcmutil sd_mod sg uas usb_storage scsi_mod r8188eu(C) lib80211 cfg80211 fuse hid_apple input_leds apple_ib_als(OE) industrialio_triggered_buffer kfifo_buf industrialio apple_ib_tb(OE) apple_ibridge(OE) joydev cdc_mbim cdc_wdm mousedev hid_generic uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 videobuf2_common videodev cdc_ncm usbhid usbnet mc hid mii snd_hda_codec_hdmi squashfs rfkill loop intel_rapl_msr intel_rapl_common x86_pkg_temp_thermal intel_powerclamp coretemp snd_sof_pci kvm_intel snd_sof_intel_byt i915 snd_sof_intel_ipc kvm snd_sof_xtensa_dsp snd_sof_intel_hda_common snd_soc_hdac_hda irqbypass snd_sof_intel_hda snd_sof snd_hda_ext_core snd_soc_acpi_intel_match i2c_algo_bit crct10dif_pclmul snd_soc_acpi crc32_pclmul ledtrig_audio drm_kms_helper ghash_clmulni_intel snd_soc_core nls_iso8859_1 snd_compress aesni_intel nls_cp437 drm ac97_bus crypto_simd vfat snd_pcm_dmaengine fat cryptd glue_helper mei_hdcp intel_gtt intel_cstate
[  232.560678] RIP: 0010:brcmf_fweh_detach+0x5b/0x60 [brcmfmac]
[  232.560730]  brcmf_detach+0x72/0xf0 [brcmfmac]
[  232.560747]  brcmf_pcie_remove+0x70/0x110 [brcmfmac]
[  232.560784]  brcmf_pcie_setup+0x38/0xd70 [brcmfmac]
[  232.560812]  brcmf_fw_request_done+0x65/0xe0 [brcmfmac]
[  232.560879] brcmfmac: brcmf_proto_detach Enter

full dmesg output is in attached file.

yurnam commented 4 years ago

is there any other way finding out what to do;

just trying to bruteforce the rambase address doesn't seem to help

ktb92677 commented 4 years ago

I am having trouble getting my Macbook Air 8,2 to get wifi. Here is what I did:

From MacOS: ioreg -l | grep RequestedFiles C-4355s-C1/hawaii.trx, C-4355s-C1/hawaii-X0.clmb, C-4355s-C1/P-hawaii-X0_M-YSBC_V-um-4.3.txt

... So I copied these files and I installed fedora.

From Fedora:

I pasted these files as such:

C-4355s-C1/hawaii.trx -> /lib/firmware/brcm/brcmfmac4355-pcie.bin C-4355s-C1/hawaii-X0.clmb -> /lib/firmware/brcm/brcmfmac4355-pcie.clm_blob C-4355s-C1/P-hawaii-X0_M-YSBC_V-um-4.3.txt -> "/lib/firmware/brcm/brcmfmac4355-pcie.Apple Inc.-MacBookAir8,2.txt"

I definitely did not make any typos when I plugged this in. The wifi does not come online. Did I miss any steps? Any help would be greatly appreciated

ktb92677 commented 4 years ago

Hey @jhohisel you seemed to have success getting the wifi drivers working on a MacBookAir8,2. Any chance you can see anything I am doing wrong with my configuration?

ktb92677 commented 4 years ago

Quick follow up, wanted to also include @ppaulweber into this conversation as you also seemed to have success at loading brcmfmac4355 successfully. Any chance you can think of what I am doing wrong? Also take a look at this thread: https://github.com/mikeeq/mbp-fedora-kernel/issues/3#issuecomment-572193109

ktb92677 commented 4 years ago

Hey @aunali1 I think it might be time to remove the check mark from MacBookAir8,y... I don't think it is loading properly at this point and the only person who claims to have gotten it to work properly has seemingly disappeared. @jhohisel

aunali1 commented 4 years ago

@ktb92677 Can you try using my kernel patches to see if that makes a difference? I also have lingering suspicions that certain revised models have entirely different FW (Ex. 15,1 2018 uses kauai whereas 15,1 2019 uses midway). Not exactly sure how to proceed, we might have to add functionality found in Apple's BCMWLAN driver that is not present in brcmfmac.

ktb92677 commented 4 years ago

@aunali1 Is this the patch you are referring to? https://github.com/aunali1/linux-mbp-arch/blob/master/wifi.patch Because if so it is nearly identical to the patch I am already using: https://github.com/mikeeq/mbp-fedora-kernel/blob/v5.4-f31/patches/wifi.patch

aunali1 commented 4 years ago

@yurnam Others have had success using the firmware archive from macOS Mojave I have hosted here: https://packages.aunali1.com/apple/wifi-fw/18G2022

yurnam commented 4 years ago

Cool, thanks, I'll try this now :)

yurnam commented 4 years ago

Sadly, no luck with the FW from Mojave. but with rambase 0x160000 i don't get a system freeze anymore, just a FW failed to initalize like before.

same with all the rambase addresses (0x160000, 0x180000, 0x198000, 0x200000)

yurnam commented 4 years ago

Update: With Rambase address 0x170000 I get: `# modprobe brcmfmac $ dmesg -w

[ 237.522523] cfg80211: Loading compiled-in X.509 certificates for regulatory database [ 237.522689] cfg80211: Loaded X.509 cert 'sforshee: 00b28ddf47aef9cea7' [ 237.545236] brcmfmac: brcmfmac_module_init No platform data available. [ 237.545247] brcmfmac: brcmf_usb_register Enter [ 237.545265] usbcore: registered new interface driver brcmfmac [ 237.545265] brcmfmac: brcmf_pcie_register Enter [ 237.545283] brcmfmac: brcmf_pcie_probe Enter 14e4:4488 [ 237.545580] brcmfmac: brcmf_pcie_get_resource Phys addr : reg space = 000000003b8600be base addr 0x00000091800000 [ 237.545581] brcmfmac: brcmf_pcie_get_resource Phys addr : mem space = 00000000d6c2949d base addr 0x00000091000000 size 0x400000 [ 237.545696] brcmfmac: brcmf_chip_recognition found AXI chip: BCM4377/4 [ 237.546156] brcmfmac: brcmf_chip_cores_check [1 ] core 0x800:64 base 0x18000000 wrap 0x18100000 [ 237.546157] brcmfmac: brcmf_chip_cores_check [2 ] core 0x812:82 base 0x18001000 wrap 0x18101000 [ 237.546158] brcmfmac: brcmf_chip_cores_check [3 ] core 0x83e:15 base 0x18002000 wrap 0x18102000 [ 237.546158] brcmfmac: brcmf_chip_cores_check [4 ] core 0x83c:64 base 0x18003000 wrap 0x18103000 [ 237.546159] brcmfmac: brcmf_chip_cores_check [5 ] core 0x812:82 base 0x18004000 wrap 0x18104000 [ 237.546160] brcmfmac: brcmf_chip_cores_check [6 ] core 0x844:2 base 0x18005000 wrap 0x18105000 [ 237.546161] brcmfmac: brcmf_chip_cores_check [7 ] core 0x840:15 base 0x18010000 wrap 0x00000000 [ 237.546161] brcmfmac: brcmf_chip_cores_check [8 ] core 0x827:35 base 0x18012000 wrap 0x00000000 [ 237.546162] brcmfmac: brcmf_chip_cores_check [9 ] core 0x240:0 base 0x00000000 wrap 0x1810c000 [ 237.546164] brcmfmac: brcmf_chip_cores_check [10] core 0x135:0 base 0x00000000 wrap 0x18112000 [ 237.546164] brcmfmac: brcmf_chip_cores_check [11] core 0x135:0 base 0x00000000 wrap 0x18113000 [ 237.546165] brcmfmac: brcmf_chip_set_passive Enter [ 237.653024] brcmfmac: brcmf_chip_set_passive Enter [ 237.653801] brcmfmac: brcmf_chip_get_raminfo RAM: base=0x170000 size=1638400 (0x190000) sr=0 (0x0) [ 237.653815] brcmfmac: brcmf_chip_setup ccrev=64, pmurev=35, pmucaps=0x84565f23 [ 237.653820] brcmfmac: brcmf_get_module_param Enter, bus=2, chip=17271, rev=4 [ 237.653828] brcmfmac: brcmf_alloc Enter [ 237.653851] brcmfmac: brcmf_fw_alloc_request: using brcm/brcmfmac4377-pcie for chip BCM4377/4 [ 237.653859] brcmfmac: brcmf_fw_get_firmwares enter: dev=0000:01:00.0 [ 237.654720] brcmfmac: brcmf_fw_complete_request firmware brcm/brcmfmac4377-pcie.bin found [ 237.654757] brcmfmac: brcmf_fw_complete_request firmware brcm/brcmfmac4377-pcie.txt found [ 237.654759] brcmfmac: brcmf_fw_request_nvram_done enter: dev=0000:01:00.0 [ 237.655106] brcmfmac: brcmf_fw_request_nvram_done nvram 000000003dcb3447 len 4940 [ 237.655541] brcmfmac: brcmf_chip_get_raminfo RAM: base=0x170000 size=1638400 (0x190000) sr=0 (0x0) [ 237.655544] brcmfmac: brcmf_pcie_download_fw_nvram Halt ARM. [ 237.655546] brcmfmac: brcmf_pcie_download_fw_nvram Download FW brcm/brcmfmac4377-pcie.bin [ 237.799783] brcmfmac: brcmf_pcie_download_fw_nvram Download NVRAM brcm/brcmfmac4377-pcie.txt [ 237.801348] brcmfmac: brcmf_pcie_download_fw_nvram Bring ARM in running state [ 237.801348] brcmfmac: brcmf_chip_set_active Enter [ 237.801828] brcmfmac: brcmf_pcie_download_fw_nvram Wait for FW init [ 238.196474] brcmfmac: brcmf_pcie_download_fw_nvram Shared RAM addr: 0x001f5de0 [ 238.196591] brcmfmac: brcmf_pcie_init_share_ram_info PCIe protocol version 7 [ 238.196603] brcmfmac: brcmf_pcie_init_share_ram_info max rx buf post 511, rx dataoffset 0 [ 238.196612] brcmfmac: brcmf_pcie_bus_console_init Console: base 2bb850, buf 268650, size 8192 [ 238.196658] brcmfmac: brcmf_pcie_init_ringbuffers Using host memory indices [ 238.196706] brcmfmac: brcmf_pcie_init_ringbuffers Nr of flowrings is 40 [ 238.196782] brcmfmac: brcmf_pcie_request_irq Enter [ 238.197454] brcmfmac: brcmf_attach Enter [ 238.197460] brcmfmac: brcmf_proto_attach Enter [ 238.197816] brcmfmac: brcmf_proto_msgbuf_attach Feeding buffers, rx data 511, rx event 8, rx ioctl resp 8 [ 238.199065] brcmfmac: brcmf_pcie_ring_mb_write_wptr W w_ptr 511 (0), ring 1 [ 238.199069] brcmfmac: brcmf_pcie_ring_mb_ring_bell RING ! [ 238.199101] brcmfmac: brcmf_pcie_ring_mb_write_wptr W w_ptr 8 (0), ring 0 [ 238.199103] brcmfmac: brcmf_pcie_ring_mb_ring_bell RING ! [ 238.199130] brcmfmac: brcmf_pcie_ring_mb_write_wptr W w_ptr 16 (0), ring 0 [ 238.199132] brcmfmac: brcmf_pcie_ring_mb_ring_bell RING ! [ 238.199138] brcmfmac: brcmf_fweh_register event handler registered for PSM_WATCHDOG [ 238.199141] brcmfmac: brcmf_bus_started [ 238.199145] brcmfmac: brcmf_add_if Enter, bsscfgidx=0, ifidx=0 [ 238.199148] brcmfmac: brcmf_add_if allocate netdev interface [ 238.199167] brcmfmac: brcmf_add_if ==== pid:340, if:wlan%d (00:00:00:00:00:00) created === [ 238.199171] brcmfmac: brcmf_bus_change_state 0 -> 1 [ 238.199177] brcmfmac: brcmf_msgbuf_query_dcmd ifidx=0, cmd=262, len=20 [ 238.199181] brcmfmac: brcmf_pcie_ring_mb_write_wptr W w_ptr 17 (0), ring 0 [ 238.199184] brcmfmac: brcmf_pcie_ring_mb_ring_bell RING ! [ 240.409699] ieee80211 phy0: brcmf_msgbuf_query_dcmd: Timeout on response for query command [ 240.409718] brcmfmac: brcmf_fil_cmd_data Failed: error=-5 [ 240.409725] brcmfmac: brcmf_fil_iovar_data_get ifidx=0, name=cur_etheraddr, len=6 [ 240.409728] brcmutil: data [ 240.409733] 00000000: 00 00 00 00 00 00 ...... [ 240.409738] ieee80211 phy0: brcmf_c_preinit_dcmds: Retrieving cur_etheraddr failed, -5 [ 240.409745] ieee80211 phy0: brcmf_bus_started: failed: -5 [ 240.409762] ieee80211 phy0: brcmf_attach: dongle is not responding: err=-5 [ 240.409767] brcmfmac: brcmf_detach Enter [ 240.437471] brcmfmac: brcmf_bus_change_state 1 -> 0 [ 240.437485] brcmfmac: brcmf_proto_detach Enter [ 240.437491] brcmfmac: brcmf_proto_msgbuf_detach Enter [ 240.439910] brcmfmac: brcmf_pcie_remove Enter [ 240.439919] brcmfmac: brcmf_detach Enter [ 240.466308] brcmfmac: brcmf_bus_change_state 0 -> 0 [ 240.466313] brcmfmac: brcmf_proto_detach Enter`

Dunedan / mbp-2016-linux

MacBook Pro 15+: Wifi Support #112

Current Status: