search

Dunkmania101 / SpatialHarvesters

A Minecraft mod that adds harvesters that gather resources from space-time itself!
https://www.curseforge.com/minecraft/mc-mods/spatial-harvesters
MIT License
3 stars 5 forks source link

[FABRIC 1.17.1] Which energy cables are supported? #55

Closed MSandro closed 2 years ago

MSandro commented 2 years ago

Hello, I tried every energy mod in my Modpack.

but no energy cable connects to an Harvester Block.

MC 1.17.1 Fabric Loader 0.12.12 Fabric API 0.46.0 spatialharvesters_Fabric_1.17.x-0.11.12d.jar

Dunkmania101 commented 2 years ago

Anything using the Reborn energy API is supposed to work. They redid it recently and I suspect they didn't update the 1.17.1 version of Tech Reborn based on this issue. Maybe I could get around this by releasing an alternative jar for 1.17.1 that uses the old version but is otherwise identical.

Cataratas commented 2 years ago

1.18.1 also has the same issue.

mnsnownutt commented 2 years ago

1.18.1 also has the same issue.

Confirm. I am trying the Benchmark II modpack and nothing works. Went into a creative world to test and only heat generators work. Tried power from Tech Reborn, Modern Industrialization, Industrial Revolution and Extra Generators and none of them will connect/work.

Dunkmania101 commented 2 years ago

It turns out I just forgot to register the tile entities using the new API. Thanks to TheVikingShip on the project's Discord for finding the problem!

Dunkmania101 commented 2 years ago

I just released 0.11.13 which should fix the problem, so I'll close this. Please reopen if it doesn't work!

JustAnOkapi commented 2 years ago

The fix does not work for me on 1.18.1 with v0.11.13 image

Cataratas commented 2 years ago

Just updated to v0.11.13a, still not working for me.

JustAnOkapi commented 2 years ago

@Dunkmania101 this should be reopened

Dunkmania101 commented 2 years ago

Gah! Sorry about this, I'll keep looking.

Dunkmania101 commented 2 years ago

I think the fix in 0.11.13 was on the right track but wasn't completely correct. Specifically, it was testing the wrong value for whether the block entity being registered should be registered as an energy handler. I've fixed that and the cables do seem to connect now in 0.11.13b. Thanks again to TheVikingShip for finding the root cause!

JustAnOkapi commented 2 years ago

The issue is fixed in the last update v0.11.13b on 1.18.1

image

0gp commented 2 years ago

When will the 1.17.1 Fix be released?

JustAnOkapi commented 2 years ago

When will the 1.17.1 Fix be released?

I think it should already be out as v0.11.13b

MSandro commented 2 years ago

spatialharvesters_Fabric_1.18.x-0.11.13b.jar is not compatible with MC 1.17.1! I can not find any 0.11.13 release for 1.17.1 on CurseForge :(

Dunkmania101 commented 2 years ago

I only released it for 1.18.x, not expecting anyone to care about 1.17.x. I'll do that one, too. It shouldn't be that hard, since the only real differences between them are which game version they get compiled for.

MSandro commented 2 years ago

any news here? this bug is still not fixed for 1.17.1!