DunoLabs / invoicetor-landing

Build beautiful invoices for your business in no time πŸ“œ
https://invoicetor.works
MIT License
10 stars 2 forks source link

πŸ› Bug: The invoice due date should be after the invoice date #31

Closed Jaspreet099 closed 1 year ago

Jaspreet099 commented 1 year ago

Is there an existing issue for this?

Current Behavior

image

If you add a due date before the invoice date, there will be no restriction or error message

Expected Behavior

The invoice due date should be after the invoice date. If someone adds a due date before the invoice date it should popup some error message adds

Steps To Reproduce

image

Environment

- Platform: Desktop
- OS: Windows 10
- Browser: Brave
- Version: v 1.44.105
- Screen Size(in inch)(Approx): 15.6

Anything else?

No response

kbhavre commented 1 year ago

Can you please assign this task to me?

isiakaabd commented 1 year ago

Has this issue been asigned to anyone yet? I would love to contribute

wh0sumit commented 1 year ago

@kbhavre & @isiakaabd I'll assign this issue to you, folks, but first It would be great if you guys could define your approach to building this feature!

isiakaabd commented 1 year ago

Thanks, @wh0sumit , I will take care of two challenges

  1. User can not add a due date beyond the current date (for example, if today is selected(10/7/2022), the due date can never be yesterday (10/6/2022).

  2. Disable the due date until the invoice date is selected or once a user tries to set due date, it shows a toast error that you need to select invoice date first and the date selected will be cleared

isiakaabd commented 1 year ago

gif

wh0sumit commented 1 year ago

@isiakaabd can you send a video after adding a date like : today's date for the invoice date and yesterday's date for the due date?

create a feature that prevents us from selecting any date before the invoice issue date; we can only select the due date as a future or present date!

isiakaabd commented 1 year ago

coverted-gif

wh0sumit commented 1 year ago

You can now create a pull request, it looks good to me🌟

isiakaabd commented 1 year ago

Thank you, Can I wait till my first PR is merged or Should proceed with second??

wh0sumit commented 1 year ago

You can raise multiple merge requests until there are no merge conflicts!

isiakaabd commented 1 year ago

Thanks, Done but its coming as two commits instead of two PRs

stale[bot] commented 1 year ago

Hi, Thanks for raising an issue! We at Dunolabs appreciate your concerns and views to help us improve. We capitalize on fostering a welcoming environment for all our contributors. This issue has not seen any activity for the past 30 days. If this issue would not see any further updates in the next 10 days, it would be automatically closed. Please comment on the issue if you would like to discuss this further. We truly appreciate your contributions and would love to hear your thoughts on the same!