🐛 Bug: Space is accepted as valid input in name field when adding an item.

[reny-pacheco]

Is there an existing issue for this?

• [X] I have searched the existing issues

Current Behavior

Adding an item with space as value for Item Name is accepted which results to empty Item Name when item is created.

Screenshot:

Preview Invoice:

Expected Behavior

Show an error for empty fields. Validate input values.

Steps To Reproduce

1. Input spaces to Item Name.
2. Input valid value to Item Quantity.
3. Input valid value to Item Price.
4. Click Add Item.
5. Item is added but with EMPTY Item Name.

Environment

- Platform: Desktop
- OS: Windows 10
- Browser: Chrome
- Version: 105.0.5195.127
- Screen Size(in inch)(Approx): 24

Anything else?

No response

[wh0sumit]

would you be interested in taking on this issue??

[reny-pacheco]

Yes, I'm interested in this issue. Please assign to me. Thank you

[wh0sumit]

I've assigned this issue to you, you can now start contributing to it :)

Happy Hacking 🌟

[isiakaabd]

@reny-pacheco I would also suggest entire validations of all inputs, you could enter a non-email address and incorrect web link and it will work fine. since formik is used, Yup will be good for validations

[reny-pacheco]

Hi @isiakaabd , That's a very good suggestion :thumbsup: , I agree that using Yup will improve the validations for all inputs. But in my own opinion, adding Yup for validation is a feature, since it makes improvement to the app. Maybe someone should raise an issue regarding that. Thank you :smiley:.

[isiakaabd]

I would like to work on it, lets see how your implementation works for the input, aside the email and web links, others have the basic validation

[wh0sumit]

@isiakaabd if you can create a separate issue for the form validation using Yup, that would be great!

[isiakaabd]

Ok, I will raise an issue about it now. Thanks

[stale[bot]]

Hi, Thanks for raising an issue! We at Dunolabs appreciate your concerns and views to help us improve. We capitalize on fostering a welcoming environment for all our contributors. This issue has not seen any activity for the past 30 days. If this issue would not see any further updates in the next 10 days, it would be automatically closed. Please comment on the issue if you would like to discuss this further. We truly appreciate your contributions and would love to hear your thoughts on the same!