👉🏻 REQUEST: Adding Yup to Formik for Validation

[isiakaabd]

Is there an existing issue for this?

• [X] I have searched the existing issues

Is your feature request related to a problem? Please describe.

Validations of Input fields using Formik,

Describe the solution you'd like

By Adding Formik, forms will be properly validated

Describe alternatives you've considered

https://formik.org/docs/overview

Additional context

No response

[wh0sumit]

@isiakaabd you can start working on this issue, happy hacking ✨

[wh0sumit]

@isiakaabd, could you please share a list of the validations you're adding so we can get a better understanding?

[isiakaabd]

Most of the fields will have this validation, until these among others are validated, the save button will not function

[isiakaabd]

link

@wh0sumit kindly check the preview, All the fields are required(and I think suggestions are welcome on that).

Merging this will create conflicts cos of other PR. It will be appreciated if the maintainer review as soon as possible and It also assist in winning prize in hactoberfest.

thank you

[wh0sumit]

After reviewing the dummy deployment, I have some suggestions:

• For now, we can just leave the validations on the fields that are not mandatory to fill; I think adding validations to the name, email, and company name fields for the user and user's client would suffice.

• It's not a good practice to hide the cursor pointer on the save button: you can show the validation errors for saving a invoice in toast, and the ctrl + s shortcut doesn't work.

• Change the validation texts to make them more clear, some words start with capital letters and some do not: UI Changes!

[isiakaabd]

I will work on it and deploy it again, I will ensure the error message is capitalized please don't forget to review our PRs

Thank you

[wh0sumit]

I'm working on it, and I'll merge your PR soon.

[isiakaabd]

Link

Here is the revised link

1. Added validation to the core part of the form and if required field not filled, on button clicked, it display error.

2. Ctrl + save isn't working yet, it throws error especially if the required field isn't filled.

For your review @wh0sumit

[wh0sumit]

I'd like to discuss validation on our discord or if you don't have discord, we can discuss it on meet, share your email address so I can create a meeting invite, and finalize some things!

FYI: we are reviewing your other PRs as well :)

here is the link to join our Discord: https://discord.gg/hjdYdqas

[isiakaabd]

Thanks, I just joined the discord group

[stale[bot]]

Hi, Thanks for raising an issue! We at Dunolabs appreciate your concerns and views to help us improve. We capitalize on fostering a welcoming environment for all our contributors. This issue has not seen any activity for the past 30 days. If this issue would not see any further updates in the next 10 days, it would be automatically closed. Please comment on the issue if you would like to discuss this further. We truly appreciate your contributions and would love to hear your thoughts on the same!