DunoLabs / invoicetor-landing

Build beautiful invoices for your business in no time 📜

https://invoicetor.works

MIT License

10 stars 2 forks source link

changes applied for inserting a footer at the bottom of each pdf #46

Closed PrakritiShetty closed 1 year ago

PrakritiShetty commented 1 year ago

Description

Fixes # (issue)

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

[ ] Test A
[ ] Test B

Development & Testing Configuration

react version:
react-router version:
SCSS version:

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have read and agree with Code of Conduct
[x] I have read and agree with Contributing

wh0sumit commented 1 year ago

Is it possible for you to share multipage Invoice PDF screenshots or video recordings??

PrakritiShetty commented 1 year ago

Sure! I made an invoice such that it spanned to two pages, and that's the watermark on the bottom left.

PrakritiShetty commented 1 year ago

Hi @wh0sumit do the screenshots look okay?

PrakritiShetty commented 1 year ago

Hi @wh0sumit and @yashsehgal, could y'all please check if this is fine? Actually I'm trying out hacktoberfest, and I really want to be in the 40,000 completing first, hence the slight urgency!

PrakritiShetty commented 1 year ago

Hi @wh0sumit and @yashsehgal could y'all reply to this thread please?

wh0sumit commented 1 year ago

due to our busy schedules lately, we have not responded to your PR. We are reviewing it now and will let you know shortly about it!

wh0sumit commented 1 year ago

we're not able to review it properly because of some conflicts. Could you please take a pull request and raise the PR again!

PrakritiShetty commented 1 year ago

Done! Could you please check the new PR (#49)?

On Tue, Oct 18, 2022 at 12:08 AM Sumit Singh @.***> wrote:

we're not able to review it properly because of some conflicts. Could you please take a pull request and raise the PR again!

— Reply to this email directly, view it on GitHub https://github.com/DunoLabs/invoicetor-landing/pull/46#issuecomment-1281311952, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARN3EFICCJMMARGXSJAWDGDWDWMI7ANCNFSM6AAAAAARETN354 . You are receiving this because you authored the thread.Message ID: @.***>