search

DuoDex / CrowdSourcedScience

Crowd Sourced Science
30 stars 32 forks source link

Fix removing "default" results #58

Closed mwerle closed 6 years ago

mwerle commented 6 years ago

This pull request retains existing "default" results or those already ending in asterisk (*) defined in mods.

Verified to fix #56.

mwerle commented 6 years ago

This functionality was originally broken by e1fb574

Olympic1 commented 6 years ago

Thanks for the fix

mwerle commented 6 years ago

Ok, now also confirmed that this fixes both of my Kemini issues.

Thanks for the quick merge, but I hope it doesn't break other mods now? I'm not entirely sure what KSP bug this plugin is actually supposed to fix and why it's needed..

Olympic1 commented 6 years ago

The plugin fixes the issue that it wasn't possible to display different reports each time the same experiment was rerun. You constantly got the same report over again.

mwerle commented 6 years ago

Hmm, ok, haven't seen that personally, but doing some reading I see that bug was only introduced "recently" (2 versions ago).

Which means my fix might break that again. I'll do some more testing.

mwerle commented 6 years ago

Ok, I tested using a temp sensor on the launchpad and additional results strings in CSS.

Using the fixed dll, it randomly selects from the original KSP-supplied results as well as the "default" and location-specific CSS ones.

Disabling the dll, it always returns the first location-specific result from CSS.

So basically, it seems to work as intended now.