search

DuoDex / CrowdSourcedScience

Crowd Sourced Science
30 stars 32 forks source link

New science messages for Sun and Laythe (and some others( #61

Closed ryaninator81 closed 5 years ago

voicey99 commented 5 years ago

I see you're adding scidefs to Default files for planets. This isn't a good idea, because default entries will override biome-specific scidefs for the whole planet, meaning you will see them repeatedly and displacing locally written ones.

voicey99 commented 5 years ago

Oh, and because the file structure has changed (not related to me) since you made your fork, these changes cannot be merged as-is. Since I've just submitted a PR of my own (#62) for other stuff, do you want me to make another commit to convert your changes to the new file structure and tag them onto my PR to merge them in that way?

ryaninator81 commented 5 years ago

Yes, thanks

Sent from my iPad

On Aug 30, 2019, at 2:56 PM, voicey99 notifications@github.com wrote:

Oh, and because the file structure has changed (not related to me) since you made your fork, these changes cannot be merged as-is. Since I've just submitted a PR of my own (#62) for other stuff, do you want me to make another commit to convert your changes to the new file structure and tag them onto my PR to merge them in that way?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.