Duqueeee / create-utilities

Adds extra utilities to the Create mod
MIT License
4 stars 9 forks source link

Void chest on train crashes train network #41

Open FireBall1725 opened 5 months ago

FireBall1725 commented 5 months ago

On startup if any trains have a void chest we get this error:

java.lang.NullPointerException: Cannot invoke "me.duquee.createutilities.blocks.voidtypes.chest.VoidChestInventoriesData.computeStorageIfAbsent(me.duquee.createutilities.blocks.voidtypes.motor.VoidMotorNetworkHandler$NetworkKey)" because "me.duquee.createutilities.CreateUtilities.VOID_CHEST_INVENTORIES_DATA" is null
at com.simibubi.create.content.contraptions.MountedStorage.handler$cja000$createutilities$deserializeVoidChest(MountedStorage.java:1062) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.contraptions.MountedStorage.deserialize(MountedStorage.java) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.contraptions.MountedStorageManager.lambda$read$1(MountedStorageManager.java:95) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.foundation.utility.NBTHelper.lambda$iterateCompoundList$2(NBTHelper.java:65) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
at com.simibubi.create.foundation.utility.NBTHelper.iterateCompoundList(NBTHelper.java:65) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.contraptions.MountedStorageManager.read(MountedStorageManager.java:94) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.contraptions.minecart.TrainCargoManager.read(TrainCargoManager.java:62) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.entity.Carriage$DimensionalCarriageEntity.read(Carriage.java:634) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.entity.Carriage.lambda$read$14(Carriage.java:500) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.foundation.utility.NBTHelper.lambda$iterateCompoundList$2(NBTHelper.java:65) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
at com.simibubi.create.foundation.utility.NBTHelper.iterateCompoundList(NBTHelper.java:65) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.entity.Carriage.read(Carriage.java:498) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.entity.Train.lambda$read$28(Train.java:1156) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.foundation.utility.NBTHelper.lambda$iterateCompoundList$2(NBTHelper.java:65) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
at com.simibubi.create.foundation.utility.NBTHelper.iterateCompoundList(NBTHelper.java:65) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.entity.Train.read(Train.java:1155) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.RailwaySavedData.lambda$load$5(RailwaySavedData.java:60) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.foundation.utility.NBTHelper.lambda$iterateCompoundList$2(NBTHelper.java:65) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at java.lang.Iterable.forEach(Iterable.java:75) ~[?:?]
at com.simibubi.create.foundation.utility.NBTHelper.iterateCompoundList(NBTHelper.java:65) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.RailwaySavedData.load(RailwaySavedData.java:59) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at net.minecraft.class_26.method_120(class_26.java:71) ~[server-intermediary.jar:?]
at net.minecraft.class_26.method_20786(class_26.java:58) ~[server-intermediary.jar:?]
at net.minecraft.class_26.method_17924(class_26.java:42) ~[server-intermediary.jar:?]
at com.simibubi.create.content.trains.RailwaySavedData.load(RailwaySavedData.java:99) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.GlobalRailwayManager.loadTrackData(GlobalRailwayManager.java:89) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.content.trains.GlobalRailwayManager.levelLoaded(GlobalRailwayManager.java:83) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at com.simibubi.create.foundation.events.CommonEvents.onLoadWorld(CommonEvents.java:171) ~[create-fabric-0.5.1-f-build.1417+mc1.20.1.jar:?]
at net.fabricmc.fabric.api.event.lifecycle.v1.ServerWorldEvents.lambda$static$0(ServerWorldEvents.java:34) ~[fabric-lifecycle-events-v1-2.2.2+1802ada577-d012b44cfa5b8a32.jar:?]
at net.minecraft.server.MinecraftServer.redirect$ddf000$fabric-lifecycle-events-v1$onLoadWorld(MinecraftServer.java:11370) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_3786(MinecraftServer.java:360) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_3735(MinecraftServer.java:324) ~[server-intermediary.jar:?]
at net.minecraft.class_3176.method_3823(class_3176.java:169) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:646) ~[server-intermediary.jar:?]
at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:265) ~[server-intermediary.jar:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]

If this NPE happens it prevents create from loading any of the trains or the train network, so upon joining the server all the trains are gone and the signals on the rail network all blink red. If the mod is removed, all the trains come back and the rail network loads without issue.

We are using the fabric version of the mod