search

DuraMAT / pv-terms

Standard Nomenclature for PV Systems
BSD 3-Clause "New" or "Revised" License
16 stars 4 forks source link

Issue 20 temperature units #23

Closed mdeceglie closed 4 years ago

mdeceglie commented 4 years ago

See #20

mdeceglie commented 4 years ago

Thanks for merging in master. It looks like this uses °C rather than °C. I will push an update.

toddkarin commented 4 years ago

I was playing with this. I found that this change makes it not possible to use excel to edit definitions.csv anymore. When excel saves the file, it adds extra characters and changes the encoding.

mdeceglie commented 4 years ago

Yes, excel corrupts data in all sorts of files and should not be used for things like this

silverman commented 4 years ago

Excel often saves csv files with an encoding that depends on the user's locale and operating system. This silently scrambles non-ASCII characters. Modern programs are expecting (assuming) the file to have been encoded with UTF-8. My opinion: whoever opens the file in Excel should just choose 'CSV UTF-8 (Comma delimited) (.csv)' as the file format in Excel's Save As dialog, instead of 'Comma Separated Values (.csv)'. This should avoid the scrambling of non-ASCII characters.