DuraMAT / pv-terms

Standard Nomenclature for PV Systems
BSD 3-Clause "New" or "Revised" License
16 stars 4 forks source link

Set of labels for different technologies #26

Open toddkarin opened 4 years ago

toddkarin commented 4 years ago

We should also standardize the labeling for different technologies, for example, pvlib.ivtools.fit_sdm_cec_sam uses the list:

while the cec database pvlib.pvsystem.retrieve_sam uses:

PVsyst on the other hand uses:

Without giving this too much thought, I would probably pick the first option and add this to pvterms. @cwhanse what do you think?

steve-ransome commented 4 years ago

Should HIT be added, and either micromorph or else say how many junctions with the amorphous? For clarity how are multi and poly distinguished as the terms have sometimes been used interchangeably.

toddkarin commented 4 years ago

The current purpose of these labels is mostly to choose band gaps and material properties for describing the cells, but in the future other applications could be expected. I would say that we want to limit the technology description to descriptions typically available on a datasheet. HIT could be added perhaps as a second level descriptor. Here's an idea:

Technology level 1

Technology level 2 (flexible labels?)

cwhanse commented 4 years ago

I'm in favor of agreeing on some string values for cell types.

FYI, in the first two cases @toddkarin lists, pvlib is accommodating terms used by SAM. For fit_sdm_cec_sam there's no choice but to use the SAM cell type label, it's passed as a value through the SAM API. For retrieve_sam, pvlib is returning the string value that appears in the CEC module database distributed with SAM.

toddkarin commented 4 years ago

Yes, I understand. Of course, we can rename cell technology in pvlib when importing from the other libraries. @cwhanse do you have an opinion on the selection and formatting? I think the CEC database naming is a little clunky and would prefer something like what I suggested above.

cwhanse commented 4 years ago

I'd suggest avoiding special characters (e.g., no spaces or hyphens), and not starting a value with a numeral if practical. As far as 'monoSi' vs. 'Si-mono', mild preference for the first, but I can see the benefit of the PVsyst style if one is scanning a list of values.

toddkarin commented 4 years ago

I would advocate for the hyphen, it makes things a little easier to parse and adds readability: Simono, thinfilm are not that great.

What about capitalization? It's not consistent to have monoSi and cdte.

shirubana commented 4 years ago

(Random comment --- I seem to remember HIT is specifically for Panasonic trademarked, otherwise they have to be called HJT? )