DuraMAT / pv-terms

Standard Nomenclature for PV Systems
BSD 3-Clause "New" or "Revised" License
16 stars 4 forks source link

Better organize PV System and PV Power Plant categories #3

Closed cwhanse closed 4 years ago

cwhanse commented 4 years ago

Proposal:

toddkarin commented 4 years ago

I'm happy with all those proposed changes. Note that the index.rst file is hardcoded, so we will need to update categories there too. Before making changes let's decide on the categories (new ones at the bottom). Any more we need?

We will probably want another html page 'Modifying standard terms' where we can describe the _XX naming scheme and the suffixes. (e.g. choosing a standard order where multiple suffixes are appended.)

kandersolar commented 4 years ago

Inverter parameters? Things like number of MPPT circuits, acceptable DC voltage/current ranges, max AC output.

cwhanse commented 4 years ago

Yes, and currently unnamed model parameters, see pvlib.pvsystem.snlinverter.

toddkarin commented 4 years ago

Okay, so our list will be:

@cwhanse : Do you want to change these snlinverter parameters to conform with the naming convention?

cwhanse commented 4 years ago

Some of the SNL inverter model parameters don't have natural names, they are just polynomial coefficients. Others can be renamed, e.g., Pnt is power_night_tare or something like that. Maybe naming model parameters can wait. We should add terms for the AC and DC capacities, max/nominal/min input voltage, etc. I'm OK having the structure and hoping someone more informed makes a PR to add the terms.

toddkarin commented 4 years ago

I'm making the changes you suggested now.

I would say that we should for now avoid model parameters that aren't used widely. E.g. perhaps single diode model parameters are widely used but inverter model params for a particular model are of secondary interest for standardization.

toddkarin commented 4 years ago

There's also the question of how to deal with a parameter like pmp, which could be a module parameter or a PV system variable.

toddkarin commented 4 years ago

I made the changes you suggested and remade the html, check it out.

cwhanse commented 4 years ago

I would say that we should for now avoid model parameters that aren't used widely.

In this case, the Sandia/CEC inverter model is the most widely used. I'm OK putting off adding terms here until there's a request to do it.

toddkarin commented 4 years ago

Added new categories.