search

DurgNomis-drol / ha_toyota

Toyota Connected Services integration for Home Assistant.
MIT License
148 stars 32 forks source link

Update hacs.json #168

Closed DurgNomis-drol closed 11 months ago

DurgNomis-drol commented 1 year ago

My reason for updating this was that this homeassistant = "^2023.11" was changed in pyproject.toml in the last PR

CM000n commented 1 year ago

My reason for updating this was that this homeassistant = "^2023.11" was changed in pyproject.toml in the last PR

Yes, but homeassistant itself is not interested in the entries in pyproject.toml. They are only relevant for local development. If you set the homeassistant requirement in the hacs.json too high, no one with an older homeassistant version will be offered ha_toyota for installation. Although it might work.

We should write tests for the custom component to see under which home assistant versions ha_toyota loads correctly via a matrix workflow with pytest. I'll see if I can write a minimal POC in the next few days.

DurgNomis-drol commented 1 year ago

You are right. As you are pointing out, we need to make sure that it will actually install on the oldest version we are supporting

That would be awesome, as I have no idea how to do that

CM000n commented 1 year ago

By the way, the linitng workflow seems to fail in your last commit against the master branch. Maybe we should add a pre-comit hook to prevent pushing commits against the master ;-)

DurgNomis-drol commented 1 year ago

Yes lets do that, it wasn't my intention, I only noticed it after I pushed it 😅