DurgNomis-drol / mytoyota

Python client for Toyota Connected Services API
MIT License
74 stars 28 forks source link

Bug: Remove stream entry from log_config.yaml #315

Closed CM000n closed 7 months ago

CM000n commented 7 months ago

Remove stream settings from logging settings.

In the course of https://github.com/DurgNomis-drol/ha_toyota/discussions/218#discussioncomment-8225268 I had another look at the log_config.yaml and realised that the stream setting has no effect.

Rather, this currently causes an error when trying to log to a file. After deleting the stream setting, logging to a file works again. E.g with python simple_client_example.py &> test.log

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cea29b0) 70.35% compared to head (863b4ef) 70.35%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #315 +/- ## ======================================= Coverage 70.35% 70.35% ======================================= Files 32 32 Lines 1511 1511 ======================================= Hits 1063 1063 Misses 448 448 ``` | [Flag](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/315/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/315/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | `70.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.