DurgNomis-drol / mytoyota

Python client for Toyota Connected Services API
MIT License
74 stars 28 forks source link

Enhancement: Remove `statistics.py` module and clean up `const.py` #317

Closed CM000n closed 7 months ago

CM000n commented 7 months ago

Just a tiny little improvement I've just stumbled across. We should use == instead of is to compare str types in stastics.py.

..::edit::.. Silly question, but is the stastics.py module still used anywhere? πŸ˜† Looks like this is a remnant and could be deleted completely?

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1a17a62) 80.11% compared to head (456b224) 82.86%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #317 +/- ## ========================================== + Coverage 80.11% 82.86% +2.75% ========================================== Files 32 31 -1 Lines 1514 1436 -78 ========================================== - Hits 1213 1190 -23 + Misses 301 246 -55 ``` | [Flag](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/317/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/317/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | `82.86% <ΓΈ> (+2.75%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CM000n commented 7 months ago

Can you please take a look at it and approve it, if the changes okay for you @GitOldGrumpy?