search

DurgNomis-drol / mytoyota

Python client for Toyota Connected Services API
MIT License
81 stars 33 forks source link

Enhancement: Revert to default logging #336

Closed CM000n closed 8 months ago

CM000n commented 8 months ago

With this PR, our central logging config is rolled back. We as lib should never overwrite the root logger of the application that uses us. This can cause problems, as all logs of the main application will be intercepted by our logger. This should fix this behaviour: https://github.com/DurgNomis-drol/ha_toyota/issues/242

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.73%. Comparing base (97c6f36) to head (58c7e63).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #336 +/- ## ========================================== + Coverage 82.66% 82.73% +0.06% ========================================== Files 31 29 -2 Lines 1442 1413 -29 ========================================== - Hits 1192 1169 -23 + Misses 250 244 -6 ``` | [Flag](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/336/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/336/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | `82.73% <100.00%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

fenty17 commented 8 months ago

Is this going to be merged soon? Just spent ages searching for the cause of my missing logs! Great work on the integration by the way.

desosav commented 8 months ago

Is this going to be merged soon? Just spent ages searching for the cause of my missing logs! Great work on the integration by the way.

You can select the specific branch until it is merged by updating the custom_components/toyota/manifest.json file in homeassistant. Replace requirements with the following and restart

"requirements": [ "mytoyota @ git+https://github.com/DurgNomis-drol/mytoyota/tree/enhancement/revert_to_default_logging", "arrow" ],

I am so glad my error messages are back :)

CM000n commented 8 months ago

Is this going to be merged soon? Just spent ages searching for the cause of my missing logs! Great work on the integration by the way.

Still waiting for approval 😞