search

DurgNomis-drol / mytoyota

Python client for Toyota Connected Services API
MIT License
74 stars 28 forks source link

Enhancement: Add hybrid_score to trip model #346

Closed rhuijben closed 1 month ago

rhuijben commented 4 months ago

Make the hybrid scrore available on the trip model.

(Tested with Toyota Corolla TS 2020)

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.58%. Comparing base (e8bd9d1) to head (16456fe). Report is 8 commits behind head on master.

Files Patch % Lines
mytoyota/models/trips.py 40.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #346 +/- ## ========================================== - Coverage 82.73% 82.58% -0.16% ========================================== Files 29 29 Lines 1413 1418 +5 ========================================== + Hits 1169 1171 +2 - Misses 244 247 +3 ``` | [Flag](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/346/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/DurgNomis-drol/mytoyota/pull/346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen) | `82.58% <40.00%> (-0.16%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Hansen#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

CM000n commented 4 months ago

Hello @rhuijben , thank you very much for your contribution! Could you run pre-commit for the linting? Otherwise the PR looks good to me so far.

rhuijben commented 4 months ago

I'll try. Not sure if the name should be score (api) or hybrid score (marketing)

Wouldn't be surprised if they use a different score for full hybrid

rhuijben commented 4 months ago

poetry doesn't work on my FreeBSD machine where I use the library. But I ran it on a linux machine and fixed some whitespace. Followed the Toyota model and called it just score now.

CM000n commented 1 month ago

Thank you very much. ❤️ Looks good to me :) Sorry for the late response, but I am currently very busy in my private life.