search

DurhamARC / raga-pose-estimation

MIT License
4 stars 1 forks source link

Issue35 automatically save output #44

Closed MarionBWeinzierl closed 4 years ago

MarionBWeinzierl commented 4 years ago

Cleans up some stuff for #35 and changes how it works, as requested by Martin. The first part was already committed to master by mistake.

MarionBWeinzierl commented 4 years ago

What's in the PR looks good to me, but a couple of comments on the previous commits to master:

Please can you change the branch back to 'master'?

Is there a chance the second part of the 'Download output' section could override things already on your Drive, e.g. if you run it on different data on different days? Would it be safer to add a date to the output zip name?

I've done the changes (borrowing your code from the form for the date string).

MarionBWeinzierl commented 4 years ago

Might be cleaner to just use:

!mv '/content/output.zip' "/content/drive/My Drive/`date +%Y-%m-%d_%H%M%S`.zip"

to avoid redefining the default_dirname function (which could potentially cause issues if we change the previous definition, as the python script in the form isn't always run when you hit 'run').

OK, changed that