DurhamAcademy / FRC2024

https://6502.team
GNU General Public License v3.0
4 stars 1 forks source link

Problem with removed code #41

Closed a1cd closed 9 months ago

a1cd commented 9 months ago

@GloryBoyK I made a mistake in reviewing your code. That means I missed a mistake in your PR. It looks like a simple problem in a merge conflict while updating git but I should have caught that in the review. I don't know how I missed that issue. Anyways, gotta get those fixed for code to work so sort of top priority rn.

I really missed some big mistakes in reviewing this code. I need to be more thorough in my review, it's important to get this stuff right. There's no rush to review because we are way ahead of schedule as programming team, and an incorrect approval can be very costly later on. Right now it's best to take our time and be accurate. (talking to me more than anyone else)

Originally posted by @a1cd in https://github.com/DurhamAcademy/FRC2024/pull/33#pullrequestreview-1850012001