DurianStallSingapore / Zilliqa-Mining-Proxy

Mining Proxy between Zilliqa Nodes and Miners
https://proxy.getzil.com
GNU General Public License v3.0
28 stars 29 forks source link

Support stratum protocol #19

Closed ShengguangXiao closed 5 years ago

ShengguangXiao commented 5 years ago

Support stratum protocol. Now support basic STATUM+TCP and STATUM2+TCP

cosminstefane commented 5 years ago

Using stratum, I noticed miner reporting hashrate as null in logs of the proxy.

ShengguangXiao commented 5 years ago

Can share the logs with me?

cosminstefane notifications@github.com 于2019年5月29日周三 下午10:22写道:

Using stratum, I noticed miner reporting hashrate as null in logs of the proxy.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/DurianStallSingapore/Zilliqa-Mining-Proxy/pull/19?email_source=notifications&email_token=ADFXQ4XS3W744NRMXFUSRLDPX2GT5A5CNFSM4HO52HIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWPPZGA#issuecomment-496958616, or mute the thread https://github.com/notifications/unsubscribe-auth/ADFXQ4SCMQ46T3O332WVIQLPX2GT5ANCNFSM4HO52HIA .

-- Best Regards, Xiao Shengguang

cosminstefane commented 5 years ago

Can share the logs with me? cosminstefane notifications@github.com 于2019年5月29日周三 下午10:22写道:

-- Best Regards, Xiao Shengguang

Ok, seems I cannot find that exact thing in logs now, maybe something changed. I will try to explain. Out of more miners, I put just one to use stratum. I am using Phoenix with "-proto 4 " flag set. All miners using standard proxy and zilminer will show in logs as bellow: [2019-05-31 10:50:24,076 INFO log.py:79] {"id": 9, "jsonrpc": "2.0", "method": "eth_submitHashrate", "params": ["0x0000000000000000", "xxxxx", "Miner6"]} The one using stratum, will not generate such a log in proxy. Also, because of this:

  1. On the main proxy webpage interface, the total number of PoW Workers will be minus this one
  2. The total hashrate shown will be also minus the one using stratum.

Hope I am more clear now.

Thank you!

ShengguangXiao commented 5 years ago

@cosminstefane I think i understand the issue, let me fix it, thanks for pointing it out.

cosminstefane commented 5 years ago

@cosminstefane I think i understand the issue, let me fix it, thanks for pointing it out.

After the update, 2 things:

  1. Some of my miners started POW for no reason, after restarting the proxy. :)
  2. Miners report hashrate (as 0), even if there is no POW window now.

Thank you for the update, will report back if any issue after next POW, will be the first one after the update. :)

L.E: Still doesn't work: Stratum: [2019-06-03 14:42:15,278 CRITICAL stratum_server.py:83] Data received: '{"id":9,"jsonrpc":"2.0","method":"eth_submitHashrate","params":["0x000000000000000000000000038ee0d4","0x9a89c92c109296c5fe7144882258fdd470ede354dcfbbbbbd3279bfb77391bbb"],"worker":"ProgPoW"}\n' Getwork: [2019-06-02 21:14:03,445 INFO log.py:79] {"id": 9, "jsonrpc": "2.0", "method": "eth_submitHashrate", "params": ["0x0000000000000000", "Here is my address", "ProgPoW"]}

ShengguangXiao commented 5 years ago

If the miner is idle, the submitted hash rate is 0, because zilliqa only do 1 minute pow every 2 hours, so most of the time the hash rate is 0. When i send some dummy pow job to the miner, the submitted hash rate is not 0

cosminstefane commented 5 years ago

If the miner is idle, the submitted hash rate is 0, because zilliqa only do 1 minute pow every 2 hours, so most of the time the hash rate is 0. When i send some dummy pow job to the miner, the submitted hash rate is not 0

Hi, in case the message was for me, I know that. What I wanted to show you is the difference as it appears in logs: With stratum and without for same miner, not the fact that 2nd message says 0. Yes, it says 0 cause POW ended.