search

Duroktar / Wolf

Wolf is a VsCode extension that enables live inspection of Python code in the editor.
Other
129 stars 7 forks source link

Wolf prompts for 'hunter' install #1

Closed jeroen-meijer closed 6 years ago

jeroen-meijer commented 6 years ago

Hello there,

I was very interested in Wolf, since it seems really cool and want to see what I can do. I'm having a problem though.

After installing it via the VS Extension Manager, I restarted VSCode and, after pressing ⌘(Cmd)+Shift+P (same as F1 on Mac) and selecting "Wolf: Set the Wolf on the current file.", it prompted me to install hunter. So I do so in my terminal window. Then I restarted, but Wolf still gives me the same prompt after activating Wolf.

schermafbeelding 2018-02-07 om 23 56 30 schermafbeelding 2018-02-07 om 23 57 30 schermafbeelding 2018-02-08 om 00 04 13

Do note, I'm using a different interpreter than the default one that VS Code selects for me. I've set my interpreter using ⌘(Cmd)+Shift+P and choosing "Python: Select Interpreter". It's currently set to /usr/local/bin/python3.

schermafbeelding 2018-02-08 om 00 06 32

Edit: I can confirm the python3 in my terminal is the same as the selected interpreter in VS Code, as shown below.

schermafbeelding 2018-02-08 om 00 08 10

Thank you for your work and help.

Best regards, Jeroen.

Duroktar commented 6 years ago

Hmm, that is odd. When I first started adding the notification for Hunter the same thing happened to me; I put in a button on that notification that will install Hunter for you (it actually installs to the --user directory, so no need for sudo). In my case, at least on my main (Arch linux) pc and (Mac) laptop, that was sufficient to make it work.

I'm going to try to reproduce your issue on my end with a fresh Python install. In the meanwhile, would you be willing to check if clicking the "Install Hunter" button fixes it? I'll let you know how it goes. Thanks again for the interest in my project, and sorry about the troubles, but these growing pains are expected and I appreciate the feedback very much.

Cheers

Duroktar commented 6 years ago

Are you using pyenv by chance? I think that I was able to reproduce the problem but can't be sure it was the same thing. On the other hand, I was looking into the python API that is now built in and I think that I can use that to ensure the correct Python binary is being run. I'm busy the first part of today, but I'll try to have an update by tonight using that.

Thanks again 🥂

jeroen-meijer commented 6 years ago

Hi there,

I’m not home right now. I’ll message you when I have an answer.

No problem. I know how difficult debugging deployment can be ;)

I don’t know what you mean by pyenv. Then again, I’m a tad tipsy, so I’ll reply whenever I have new information.

Best regards

Op 8 feb. 2018 om 15:06 heeft traBpUkciP notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

Hey there! Are you using pyenv by chance? I think that I was able to reproduce the problem but can't be sure it was the same thing. On the other hand, I was looking into the python API that is now built in and I think that I can use that to ensure the correct Python binary is being run. I'm busy the first part of today, but I'll try to have an update by tonight using that.

Thanks again 🥂

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Duroktar/Wolf/issues/1#issuecomment-364121272, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANoVFSIYwL5S139l88bTJzA1MDjsfWUGks5tSv9jgaJpZM4R9imf.

Duroktar commented 6 years ago

Oops, I don't remember closing this. I think GitHub did for me cause I mentioned #1 in the last commit message.

Anyways. I tweaked the code around last night, I was injecting the script path into the Python shell and think it might have been overriding some local settings, so it's now removed. It seems to allow me to go through the install procedure that you went through and not complain about finding Hunter so if you can give it a shot at some point I'd be very interested to know if it fixes it for you too.

I hope ya had a good one :) I ended up having a couple pops last night also, so I hope I didn't mess anything up too bad, haha.

Cheers

jeroen-meijer commented 6 years ago

Hi,

I was already reading the commit comment through and didn’t see anything related to my issue. Glad to know I was right.

I’ll try it out tomorrow or sooner if I can find the time.

Nice, cheers indeed ;)

Best regards.

Op 9 feb. 2018 om 16:57 heeft traBpUkciP notifications@github.com<mailto:notifications@github.com> het volgende geschreven:

Oops, I don't remember closing this. I think GitHub did for me cause I mentioned #1https://github.com/Duroktar/Wolf/issues/1 in the last commit message.

Anyways. I tweaked the code around last night, I was injecting the script path into the Python shell and think it might have been overriding some local settings, so it's now removed. It seems to allow me to go through the install procedure that you went through and not complain about finding Hunter so if you can give it a shot at some point I'd be very interested to know if it fixes it for you too.

I hope ya had a good one :) I ended up having a couple pops last night also, so I hope I didn't mess anything up too bad, haha.

Cheers

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Duroktar/Wolf/issues/1#issuecomment-364474323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANoVFWyLgEreue31Q7QlzQtKAedBnXYeks5tTGrmgaJpZM4R9imf.

Duroktar commented 6 years ago

Yeah, no you were definitely right. Github is a little too smart when I put a commit message like:

  removed cwd argument from python spawner, hopefully this fixes #1

It saw the "fixes" and "#1" so it thought it was closed. So, anyways, yeah sometime when you get a chance give it a rip. I'll keep the issue open until you're happy :)

:beers:

Duroktar commented 6 years ago

Closing for now. Feel free to re-open it anytime though. Thanks again!

jeroen-meijer commented 6 years ago

Hey there, sorry for not getting back to you for so long, other things got in the way. Got a new Mac since last time, and I'm getting the same error again. I've installed hunter in all ways I know of, pip install, pip3 install, python3 -m pip install.., etc. I've changed my python environment within VS Code to python3: image

Almenon commented 6 years ago

When my pull request is merged in you will not need to install Hunter anymore. :)

Duroktar commented 6 years ago

@0916174 Hey there! Sorry for the delay getting back to you. As @Almenon mentioned above, he wrote a patch that should fix this issue once and for all. I merged it in today with v0.3.10-patch and it's already been pushed to the extension store. So go ahead and Update to the latest version and let me know if that solves the issue for you. I'm pretty confident that it will work.

Thanks for showing interest in Wolf and thanks for sticking through with this issue! :beers: