Duroktar / Wolf

Wolf is a VsCode extension that enables live inspection of Python code in the editor.
Other
129 stars 7 forks source link

can't launch python in forked repo #26

Closed Almenon closed 6 years ago

Almenon commented 6 years ago

Was about to raise an issue with the microsoft python extension and then I realized that you have the python path hardcoded in your user settings XD

I'll parse down the settings to its most basic form and add it to the gitignore so we can maintain our own versions.

(I'll submit a pull request for this)

Almenon commented 6 years ago

the line in question:

"python.pythonPath": "${workspaceFolder}/python_modules/bin/python3",

Was wondering why python was trying to use a nonexistant python_modules folder ... lol

Almenon commented 6 years ago

Actually, adding to gitignore wont work. I did the following

git update-index --assume-unchanged .vscode/settings.json

https://stackoverflow.com/questions/9794931/keep-file-in-a-git-repo-but-dont-track-changes

Almenon commented 6 years ago

a alternate solution would be to just delete settings.json from the repo. In hindsight that might have been simpler than running git update-index.

Duroktar commented 6 years ago

You can do pip install nip.cli and then run nip install from the project directory and it will all just work. Then you can get the NIP-Scripts Extension and be able to run the tests from a menu in the sidebar!

Maybe I should put this note in the README..

Almenon commented 6 years ago

User settings should be up to the user - for example, a user might use nvm (node version manager) instead of nip

Duroktar commented 6 years ago

Nip is really only a wrapper around a python virtual environment. So running nip install just spins a virtual environment up in the python_modules folder. Then you can add scripts to the nip.json file (like the package.json file) and commands in those scripts are run within the virtual environment. You can also still use npm, because nip is basically just a venv utility. The only time python_modules is coded in is for debugging in the tasks.json file. So nip saves a few steps (installing hunter, and the auto code formatters, etc.. that are also in the settings file.)

But I'm speaking before I've even looked at the PR :D So I'm sure you have something workable and I'll merge it up. I'll get back to ya. Good feedback BTW

Edits: Bunch of spelling

Almenon commented 6 years ago

Oh i was looking at nip (node env) (instead of nip.cli, py env) man those names are confusing

On Sat, Mar 17, 2018, 12:21 PM traBpUkciP notifications@github.com wrote:

Nip is really only a wrapper around a python virtual environment. So running nip install just spins a virtual environment up in the python_modules folder. Then you can add scripts to the nip.json file (like the package.json file) and command in the script is run within that virtual environment. You can also still use npm, because it's just a venv. The only time that folder is coded in is for debugging in the tasks.json file. So nip saves a few steps (installing hunter, and the auto code formatters, etc.. that are in the settings file.)

But I'm speaking before I've even looked at the PR :D So I'm sure you have something workable and I'll merge it up. I'll get back to ya. Good feedback BTW

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Duroktar/Wolf/issues/26#issuecomment-373945967, or mute the thread https://github.com/notifications/unsubscribe-auth/AMeZhaF53OMmmipaHb_gseQg4dnuTp90ks5tfWJQgaJpZM4Su2-h .

Duroktar commented 6 years ago

Nip Isn't Pip .. I was feeling clever that day lol

Duroktar commented 6 years ago

Feel free to close or leave this one up. I don't know if it may help others having similar issues or not. I put an FAQ tag on it anyways.