search

Duroktar / Wolf

Wolf is a VsCode extension that enables live inspection of Python code in the editor.
Other
128 stars 7 forks source link

wolf doesn't handle baseExceptions #56

Open Almenon opened 3 years ago

Almenon commented 3 years ago

This is a minor problem and a easy fix.

raise Exception('hi') - wolf works raise BaseException('hi') - wolf doesn't output anything

fix: in wolf python code catch BaseException instead of regular Exceptions.

Almenon commented 3 years ago

I tested it w/ wolf 0.4.3 and python 3.7.1 32-bit on windows 10 but still doesn't work unfortunately. Same behavior. I don't see any errors in the dev tools console or in the extension output.

Duroktar commented 3 years ago

I shall add Python 3.7 to the test matrix and see if it reproduces. Thanks for sticking to it :100:

Duroktar commented 3 years ago

Sheesh.. I just realized I don't even have a test case for exception handling :yanks_tie:

Duroktar commented 3 years ago

Very strange.. Commit 781788b isn't in master. I must have screwed up a git command along the line somewhere.. fixing now.

Duroktar commented 3 years ago

Bahaha, I pushed a branch with the fix the other day but never made the PR :laughing:

PS: I'll wait to release an updated version of the extension until I've tried to fix #59. If I can patch both at once that would be much better methinks..