DusanKasan / Knapsack

Collection pipeline library for PHP
http://dusankasan.github.io/Knapsack/
MIT License
536 stars 56 forks source link

PHP 8.0 - uasort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero #72

Closed martinvenus closed 3 years ago

martinvenus commented 3 years ago
martinvenus commented 3 years ago

I could try to prepare PR. Should I? Because I can see some issues without any reaction (for example https://github.com/DusanKasan/Knapsack/issues/69, https://github.com/DusanKasan/Knapsack/issues/70, https://github.com/DusanKasan/Knapsack/issues/71), so I'm not sure if someone will look at it.

martinvenus commented 3 years ago

The problem is not in DusanKasan / Knapsack library. Actually it was in my application (sort function implementation). I have to apologize and close issue.