search

Dusk-Labs / dim

Dim, a media manager fueled by dark forces.
GNU Affero General Public License v3.0
3.83k stars 165 forks source link

Support for Shoko Server (to handle anime metadata) #354

Open Aigis opened 2 years ago

Aigis commented 2 years ago

Is your feature request related to a problem? Please describe. I genuinely like the look and feel of Dim from the test install I spun up, but the anime metadata situation is... hit or miss (and when it's a miss I can't edit it yet). Shoko (https://github.com/ShokoAnime/ShokoServer) is something that I've run in the backend for both Plex and now Jellyfin, and has made my collection show up flawlessly as it handles all of the lifting for me regardless of the media server setup I've had.

Describe the solution you'd like Support for pulling metadata from Shoko Server.

Describe alternatives you've considered Waiting for the ability to manually edit metadata through Dim, there's not really anything more I can do, but I'd love to daily drive this.

Additional context I'm not a code savvy person, so if there's anything that needs to be done from the Shoko Server team to support this I'd be more than happy to submit the feature request there, but I'm not sure what if at all would need to be done on that side, but support for Shoko would serve the one problem I've encountered with Dim

bigretromike commented 2 years ago

or just add anidb.net support for scanner https://wiki.anidb.net/API

vgarleanu commented 2 years ago

or just add anidb.net support for scanner https://wiki.anidb.net/API

Unfortunately AniDB is quite hostile when it comes to their API limits and their licensing. I'm more keen on adding support for MAL or some MAL mirror with laxer API limits.

bigretromike commented 2 years ago

hostile maybe, still the best place to compare files containing anime, sadly nothing better than that. but I understand why you wouldn't what to touch it

vgarleanu commented 2 years ago

still the best place to compare files containing anime, sadly nothing better than that.

What do you mean by "compare files". In my opinion anidb is overrated and there are metadata apis that have comparable quality.

I'd add support for AniDB if they allowed us to create a mirror of anidb that aggressively caches API requests. Atm 3 requests per second (iirc it might actually be per 10s not sure) really sucks. Dims scanners are highly concurrent to the point where the actual metadata searches take most of the time.

Tmdb is ideal because they don't have any limits on requests per second and allow third party mirrors/public cache.

bigretromike commented 2 years ago

Understandable. I would like to know which APIs you talk about are more q comparable. The biggest advantage of using anidb is that it use hashes to compare files not file names. While using names you probably can get more compatible apis using hash guarantee you a 100% match if any is found. But I fully understand the point you are making. About caching AniDB allow caching on client side - which in real life application is great only for reimporting your own collection.

I just wanted to point its better to query anidb directly than relying on ShokoServer, but if that is a know thing then I rest my case ;-)