DuskSystems / wayfind

A speedy, flexible router for Rust.
Apache License 2.0
8 stars 0 forks source link

Fix same-branch matching #149

Closed CathalMullan closed 1 month ago

CathalMullan commented 1 month ago

Solve it stupidly first, then worry about performance. We might need to introduce a 3rd state to quick_dynamic?

EDIT: No, solution is quite simple actually. Shouldn't impact performance that much. Won't appear on benchmarks, since none of our benchmarks measure inline search speed.

Let's add more tests too.

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #149 will not alter performance

Comparing 148-router-fails-to-route-to-more-specific-options (517c1ee) with main (0a3ceb0)

Summary

✅ 16 untouched benchmarks

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/node/search.rs 87.87% 1 Missing and 3 partials :warning:
Files with missing lines Coverage Δ
src/node/search.rs 78.71% <87.87%> (+0.60%) :arrow_up: