Fix: issue 26 - revert a failed decryption

Dustin-Ray / capyCRYPT

An experimental high-performance cryptosystem.

MIT License

12 stars 1 forks source link

Fix: issue 26 - revert a failed decryption #51

Closed Hyunggilwoo closed 8 months ago

Hyunggilwoo commented 9 months ago

If password2 tries to decrypt a text that was encrypted with password1, then the message will return back to the text encrypted with password1.

Added the features to sha3_decrypt and key_decrypt. Created tests for the 4 security parameters (224, 256, 384, 512) both sha3_decrypt and key_decrypt.

Dustin-Ray commented 9 months ago

you have a conflict with main that needs to be resolved before merging this pr heads up

Dustin-Ray commented 9 months ago

you fixed it! nicely done. merging this PR into main just requires you to format the code correctly. please run:

cargo clippy cargo fmt cargo test cargo check

to ensure that everything is clean and tidy. also please note the comment on the tests on using .unwrap() instead of the match statements. its ok to use unwrap() in test code.

Dustin-Ray commented 9 months ago

looks great! to merge, address these items:

[x] try to condense the test case down to a single parameter, we dont really need to test all of them since they are already covered in other test cases
[x] you may need to pull in the new changes to the docs from your other PR #46
[x] at the very end before you push everything up, run cargo fmt
[x] mark all of the comments on this page as resolved if you have addressed them properly

Dustin-Ray commented 9 months ago

merging this to main requires resolving the conflicts from your previous PR but you should be able to easily do it from the web editor