search

Dustyroom / flat-kit-doc

Documentation of the Flat Kit asset.
https://flatkit.dustyroom.com
Apache License 2.0
2 stars 1 forks source link

Water shaders look completely different from sample video (URP) #2

Closed spvn closed 3 years ago

spvn commented 3 years ago

Hi I just bought your asset and hope this is the right place to report an issue. This is what my water demo scene looks like. I have not made any changes since importing the asset. As you can see, the objects in the top row aren't even transparent like in the demo video I saw on the asset store page.

image

I'm using Unity 2019.4.1f1, and am on URP 7.3.1, version 2.0.6 of your asset. Any idea what's causing this problem?

dustyroom-studio commented 3 years ago

Thank you for reporting the issue. We'll look into it and write back.

dustyroom-studio commented 3 years ago

Could you please navigate to Project Settings -> Graphics and insert [FlatKit] Example Settings URP file into Scriptable Rendering Pipeline Setting field. Please, do this in Quality tab's Rendering field as well. Let us know if it still don't work.

spvn commented 3 years ago

Adding it to Graphics tab only did not work, but it worked once I added it to Quality tab as well. May I know what are the important settings to change from the default URP render pipeline asset to make the water shaders look correct?

Also, how viable are these water shaders on mobile in your opinion (when used sparingly)?

Thanks a lot for the reply.

dustyroom-studio commented 3 years ago

In the Universal Rendering Pipeline Asset settings, there should be Depth Texture and Opaque Texture turned on. These settings are off by default.

The water shader should work well on mobiles. If you've got an issue with getting it to work with mobiles, send us a message to info [at] dustyroom [dot] com

spvn commented 3 years ago

Sorry to add on but I've realised that the water shader doesn't work with an Orthographic camera... I didn't see this limitation stated anywhere in the documentation. Slightly disappointed about that... It looks ok in the scene view but is broken in Game view. I'm guessing this is an unfortunate limitation of the shader?

image

dustyroom-studio commented 3 years ago

This must be a bug with the water shader, we weren't aware it fails with an ortho camera. We'll take a look and update here.

Jointy87 commented 3 years ago

Hiya,

Very glad to see you guys are working on an update on this. Do you perhaps have a rough ETA on when you believe this update will go live? And when it goes live, I can just update it via my Package Manager as per usual?

Thank you for your time and effort on this. Cheers,

dustyroom-studio commented 3 years ago

Hi, it's really hard to say what time it will take but it is a high priority one, so it shouldn't take long. And yes, there will be a notification about a free update in Package Manager.

Jointy87 commented 3 years ago

Thanks :)

dustyroom-studio commented 3 years ago

This should be now fixed in Flat Kit 2.0.6. Please re-open the issue if it is not resolved.