search

DutchCodingCompany / filament-socialite

Add OAuth login through Laravel Socialite to Filament.
MIT License
153 stars 38 forks source link

Localization strings need Package Namespace #44

Closed gn0rt0n closed 10 months ago

gn0rt0n commented 1 year ago

Example:

dutchcodingcompany/filament-socialite/src/Http/Controllers/SocialiteLoginController.php 162: return $this->redirectToLogin('auth.registration-not-enabled');

should be:

dutchcodingcompany/filament-socialite/src/Http/Controllers/SocialiteLoginController.php 162: return $this->redirectToLogin('filament-socialite::auth.registration-not-enabled');

Without this, you will not get proper registration failure messages when using this with other packages like Breezy. There are probably other places this needs to be changed. I didn't have time to create a PR. Sorry ☹️

ghost commented 10 months ago

Fixed in upcoming release (for Filament v3) https://github.com/DutchCodingCompany/filament-socialite/pull/46