DutchJelly / CraftEnhance

A Minecraft Plugin that allows server owners to create custom recipes in-game
Apache License 2.0
13 stars 11 forks source link

custom recipes cannot match another #60

Closed 5eveNight closed 2 months ago

5eveNight commented 11 months ago

maybe only i meet this bug i use paper-1.20.1-196.jar and java 17 and CraftEnhance-2.5.9.2.

i create some recipes like below: recipe 1:a normal coal add four diamond become a special coal (for example,type coal,named super coal,with some lores) image

recipe 2:two special coal combine (shapeless) become another special coal (for example,type coal,named ultra coal,with some different lores) image

then the bug comes when i drag two normal coal into crafttable,they could product ultra coal! image

yes,i try every matchtype: MATCH_NAME / MATCH_META / MATCH_MODELDATA_AND_TYPE / MATCH_NAME_LORE and i try command /ceh reload,try restart the server and i try gamemode creative or survival all these are useless i remembered that the first time after i create these recipes,they works well. maybe yesterday or the day before yesterday,i stop the server. today i start the server,meet the bug. waiting for your reply.

5eveNight commented 11 months ago

oh sh*t if i use CraftEnhance-2.5.9,all work perfect! so there is a bug hide in CraftEnhance-2.5.9.2

5eveNight commented 11 months ago

damn it. after restart server, CraftEnhance-2.5.9 also has this bug

5eveNight commented 11 months ago

ok i understand CraftEnhance-2.5.9 only show the product, i CANNOT drag out the product from slot, and after cancel craft, second time will not show the product(work perfect) CraftEnhance-2.5.9.2 show the product, and i CAN drag out the product into inventory, absolutely BUG.

broken1arrow commented 10 months ago

ok i understand CraftEnhance-2.5.9 only show the product, i CANNOT drag out the product from slot, and after cancel craft, second time will not show the product(work perfect) CraftEnhance-2.5.9.2 show the product, and i CAN drag out the product into inventory, absolutely BUG.

Sorry for late replay, I don't think I have change the logic in crafting between 2.5.9 and 2.5.9.2. But you mean you can take the product from crafting table or the gui?

Could you send a video about the issue?

5eveNight commented 10 months ago

[自动回复]:来信已收到,我将会尽快给您回复

broken1arrow commented 10 months ago

Your first issue I could not recreate. I have others complain on same thing, but even on latest Minecraft version I have not yet get that bug.

5eveNight commented 10 months ago

ok i understand CraftEnhance-2.5.9 only show the product, i CANNOT drag out the product from slot, and after cancel craft, second time will not show the product(work perfect) CraftEnhance-2.5.9.2 show the product, and i CAN drag out the product into inventory, absolutely BUG.

Sorry for late replay, I don't think I have change the logic in crafting between 2.5.9 and 2.5.9.2. But you mean you can take the product from crafting table or the gui?

Could you send a video about the issue?

sorry for reply you soooo late. I reproduce the BUG by 2.5.9.3 plugin, and record a video about 16 MB , maybe it is not very good to upload the BUG video to youtube, so if you mind message me a email to receive the full video. here the test: JAVA 17; paper-1.20.1-196.jar; only 2 plugins:CraftEnhance-2.5.9.3.jar ,PlayerIntensify-2.1.2.jar( RPG plugin for special coke).

recipe 1:two special coke(green name) combine to one ultra coke(gold name),shapeless ,MATCH_MODELDATA_AND_TYPE R1-1 R1-2 R1-3 recipe 2:one ultra coke decomposed into two special coke,shapeless ,MATCH_MODELDATA_AND_TYPE R2-1 R2-2 R2-3

GIFs about BUG: BUG 1: two normal coke combine to one ultra coke 1 00_00_00-00_00_30 BUG 2: one normal coke decomposed into two special coke 2 00_00_00-00_00_30

5eveNight commented 10 months ago

last time i try all kinds of MATCH,none works. if i change back to 2.5.9, it works well. but the GUI of 2.5.9 cannot change the set of any recipe(i click the button, but no response, i don't know why) only i stop the server and change recipes.yml.

5eveNight commented 10 months ago

last time i try all kinds of MATCH,none works. if i change back to 2.5.9, it works well. but the GUI of 2.5.9 cannot change the set of any recipe(i click the button, but no response, i don't know why) only i stop the server and change recipes.yml.

emmmmm i restart the server, and change to MATCH_NAME_LORE. 2.5.9.3 works well. maybe i made some mistakes last time

broken1arrow commented 10 months ago

last time i try all kinds of MATCH,none works. if i change back to 2.5.9, it works well. but the GUI of 2.5.9 cannot change the set of any recipe(i click the button, but no response, i don't know why) only i stop the server and change recipes.yml.

emmmmm i restart the server, and change to MATCH_NAME_LORE. 2.5.9.3 works well. maybe i made some mistakes last time

Match_meta should work also. But that mode is ok also.