DuyDoan190203 / RacketRain

Badminton-Store developed by NET7
0 stars 0 forks source link

Fullstack-project review #1

Open ShootingStar91 opened 3 months ago

ShootingStar91 commented 3 months ago

Fullstack-project review

This is a review for your fullstack project. You do not need to implement any suggestions here to receive your credit.

User experience

Code

Overall

The application has all the necessary functionalities for a web-store. It looks stylish and polished, with an easy-to-use interface. Under the hood, the code uses different technologies in a smart way to handle different issues like styling or state and query management. The code quality is good, and the features of React are well utilized. Great job! :gem:

DuyDoan190203 commented 3 months ago

Hi Arttu, Thank you for your time and the review email. I really appreciate it. I think your suggestions are super helpful, especially the code prettier as i am using it but not much. Kind regards, Duy

On Thu 11. Apr 2024 at 14.23, Arttu Kangas @.***> wrote:

Fullstack-project review

This is a review for your fullstack project. You do not need to implement any suggestions here to receive your credit. User experience

  • The website looks good, with a large image on the front page and a clear navigation bar
  • The UI overall looks polished, clear and simple to use
  • The application has different views, like searching and filtering different items from catalogue, and viewing individual items, or shopping cart
  • The functionalities seem to be working well
  • The forms look good, they have good validations and error messages
  • Overall, seems to have a good amount of functionalities, and a polished look and feel. Good job! 👍

Code

  • The frontend is Typescript-React, while the backend uses C#. I have little experience with the latter so I will focus on the frontend, but the backend code does not look bad at a glance.
  • The React-code looks good, overall. Things are separated in sensible-sized components and files.
  • You utilize React's features like Context API's and libraries like react-router and Material UI in a good way
  • Redux Toolkit is used to handle API-calls and state. It's a good choice
  • I recommend using a code formatter, such as Prettier which is also mentioned on the course (part 6 or 7). Formatting the code is especially important when others read your code, and I recommend getting used to it yourself too. It really helps reading the code. Although, in your code there was no huge issues, but little things like try{ instead of try { or const[darkMode, setDarkMode] = ... look 'messy' once you're used to code formatting.

Overall

The application has all the necessary functionalities for a web-store. It looks stylish and polished, with an easy-to-use interface. Under the hood, the code uses different technologies in a smart way to handle different issues like styling or state and query management. The code quality is good, and the features of React are well utilized. Great job! 💎

— Reply to this email directly, view it on GitHub https://github.com/DuyDoan190203/RacketRain/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5SZID3BOGXMFMUY4BHD3V3Y4ZXEHAVCNFSM6AAAAABGCDPI32VHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZTONBZGA4DGOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>