Duzos / fakeplayer

Duzo's Fake Players Minecraft Mod
https://modrinth.com/mod/fake-players
Other
3 stars 3 forks source link

Custom skins not working (1.20.1 Fabric) #6

Open ChristianSoldier777 opened 1 year ago

ChristianSoldier777 commented 1 year ago

Hey so first of all, thank you SO much for making a Fabric version for 1.20.1. Unfortunately, I have an issue where the custom skin screen (when you hit shift+rightclick) is bugged out and won't do anything when I hit "Done". Image attached.

Screenshot 2023-10-02 at 6 35 48 PM
Creativious commented 1 year ago

Are you using the latest release on the github?

Creativious commented 1 year ago

I redid the gui on the latest version v1.1.0 and v1.1.1 are working with a new gui. v1.1.1 has some fixes to the scaling of the gui.

ChristianSoldier777 commented 1 year ago

I used ATLauncher to get the mod. I'll get it from GitHub and try again.

Creativious commented 1 year ago

I do the fabric ports/version and I don't have access to the curseforge or modrinth. So latest versions are usually on here.

ChristianSoldier777 commented 1 year ago

okay so I got it from GitHub and it's still not working. It says it's not functioning yet.

Screenshot 2023-10-02 at 6 53 05 PM
Creativious commented 1 year ago

Yeah I don't have the changing the skin thing implemented for changing it live. If you want to change it normally you'll have to rename the spawn egg. It crashes the changing it live for right now. In the process of trying to get it to work. The way to get a custom skin to work is use a custom name and then go into the fakeplayers/cache folder inside of .minecraft

Say you used the name test

It'll be test.png and replace that file with whatever skin you want.

Sorry it's so off, custom skins aren't working how I want it to rn.

ChristianSoldier777 commented 1 year ago

That's fine, I know coding/programming is difficult and takes time. Thank you for your help.

Creativious commented 1 year ago

It's the best solution I can offer for custom skins at the current moment

ChristianSoldier777 commented 1 year ago

Sorry to keep bothering you, but when I try to rename the egg it crashes the game...is there any way around it?

Creativious commented 1 year ago

Can you send me the crash log?

ChristianSoldier777 commented 1 year ago

latest.log

Creativious commented 1 year ago

What other mods are you using and what operating system are you on?

Creativious commented 1 year ago

I ended up figuring out the problem. I'll see if I can get a fix out in the next few hours. Currently busy, but I'll see if I can put out a fix as soon as possible. The mod works in a dev environment. I must've forgot to include a class in the jar file.

ChristianSoldier777 commented 1 year ago

I'm on MacOS Ventura, and I'm using these mods:

Screenshot 2023-10-02 at 7 16 40 PM
ChristianSoldier777 commented 1 year ago

ah ok thank you

Creativious commented 1 year ago

I'll send a message in here with the release link when I make the fix. It'll be out within the next 2-4 hours whenever I get time.

ChristianSoldier777 commented 1 year ago

Not to rush you or anything, but will it take more time than you previously said?

Loqor commented 1 year ago

Not to rush you or anything, but will it take more time than you previously said?

Give it some time, it's a process. We will get to it when we get to it. Like he said, he'll let you know when he fixes it.

ChristianSoldier777 commented 1 year ago

Alright, sorry for bothering you. Thanks

Creativious commented 1 year ago

Sorry I ended up getting stuck and busy with something else. I'll try to get it out as soon as possible. The problem is a bit harder to solve then I initially thought

Creativious commented 1 year ago

https://github.com/Duzos/fakeplayer/releases/tag/v1.1.2-1.20.1-FABRIC

Is the new latest release, sorry for taking so long had trouble fixing this problem.

Creativious commented 1 year ago

@ChristianSoldier777

Creativious commented 1 year ago

Let me know if you have any other problems, otherwise I'm going to close this within the next 24-48 hours. Thanks for letting this come to my attention!

ChristianSoldier777 commented 1 year ago

Thank you for being so awesome and helping me out. Unfortunately...I'm still having issues. The cache folder doesn't have anything in it, but I tried putting a skin texture in it anyway (using the name "test.png" to match an npc I added in a world with the name "test"). It didn't work and the npc still has the default black-and-purple texture.

Creativious commented 1 year ago

Odd, the mod works as intended now inside of a new multimc instance. Can you send your latest log?

ChristianSoldier777 commented 1 year ago

I’ll send the log once I’m off work today. 👍

ChristianSoldier777 commented 1 year ago

latest.log This was from me naming and placing a "test" player egg while there is a "test.png" skin image in the empty cache folder.

ChristianSoldier777 commented 1 year ago

also I just noticed a "skins" folder in the base directory of the instance (I'm using ATLauncher). It doesn't have anything in it, but I'll try putting the skin image into it, maybe it has something to do with the mod?

ChristianSoldier777 commented 1 year ago

...nope, the "skins" folder does nothing (as far as I can see)

Creativious commented 1 year ago

That's from a previous version of the mod that you used, the first one.

When you rename a spawnegg and spawn the player with it, do they get a custom skin or not?

If they don't that means that for some reason java doesn't like writing on mac.

image

You should see things like this inside of the cache directory if it's saving files properly.

Creativious commented 1 year ago

Let me know if anything even shows up automatically when you are renaming an egg and then spawn a player.

ChristianSoldier777 commented 1 year ago

The file path "fakeplayers/cache/" is created, but nothing else. The fake players themselves only have the default purple-and-black skin, and there's nothing in the cache folder.

ChristianSoldier777 commented 1 year ago

WAIT I FIGURED IT OUT

I tried opening/running ATLauncher using sudo in the terminal, so it can have permission to write files, and it's finally working!

ChristianSoldier777 commented 1 year ago

Idk if there's a way to have it work without having to use sudo though...

Creativious commented 1 year ago

Odd, I'll see if there's an alternate way of writing files for mac. This also means I should pop over to linux and make sure it works on there.