search

Dvlv / BoxBuddyRS

A Graphical Interface for Distrobox
MIT License
229 stars 24 forks source link

Various translation related additions #24

Closed VortexAcherontic closed 7 months ago

VortexAcherontic commented 7 months ago

Hello there, by this Pull Request I'd like to merge an updated boxbuddyrs.pot file including text I added in the previous PR.

In addition I added a German translation (native) and updated uk_UA, ru_RU and it_IT using DeepL to include the newly introduced messages as well as adding some which where already missing.

Furthermore I issued a small update on the create-pot.sh script to work on different users by using $HOME instead of a fixed user path. Also I added a quick dependency check which tests if xtr is installed in $HOME/.cargo/bin/ and if not will run cargo install xtr and then generate the pot file.

Kind regards,
V

Dvlv commented 7 months ago

Thank you!

I don't think I meant to commit the create-pot script, but it's nice now to have it actually usable. Regenerating the .pot is going to remove my context comments, so I guess I need to move them to a separate file.

Not sure how I feel about machine-translations, but I suppose it's fine just for these couple of strings.

I'll merge this when I've got the Custom Home Dir stuff all figured out.

VortexAcherontic commented 7 months ago

Regenerating the .pot is going to remove my context comments, so I guess I need to move them to a separate file.

I apologize for this did not payed proper attention to this. I re-added the comments.

Not sure how I feel about machine-translations, but I suppose it's fine just for these couple of strings.

I agree at some point the question arises if it is better to have no translation or possibly broken translations 😄
Maybe @albanobattistella could revisit the changes on it_IT and @vovkiv could revisit the changes on uk_UA and ru_RU?

Vovkiv commented 7 months ago

Oh, wowie Yes, I will maintain Ukrainian and Russian translation myself, no need to touch it by machine translation in future, just ping by @Vovkiv.

Vovkiv commented 7 months ago

@Dvlv

I don't think I meant to commit the create-pot script, but it's nice now to have it actually usable. Regenerating the .pot is going to remove my context comments, so I guess I need to move them to a separate file.

I think you meant to add this comments in source code, near line where string taken, with TRANSLATORS: keyword, refer to rust gettext implementation or GNU gettext https://www.gnu.org/software/gettext/manual/gettext.html#PO-Files

VortexAcherontic commented 7 months ago

Many thanks @Vovkiv I included the suggested changes.