Dvlv / BoxBuddyRS

A Graphical Interface for Distrobox
MIT License
229 stars 24 forks source link

[Feature request] Adding volumes while creating a new Distrobox container #25

Closed VortexAcherontic closed 7 months ago

VortexAcherontic commented 7 months ago

Hey there, I'd like to open this request primarily for the record but also for discussion about such a feature.
I would like add this myself in a future PR if approved.

When creating a new distobox container some can pass multiple of --volume /host/path:/container/path to the distrobox-create command to allow a container to access none default path on the host system.

Probably there are not many requiring this feature but would be a neat addition.

My proposal would be to add a List at the bottom of the distrobox create ui where the user can add and remove multiple entries.
similar to this (cheaply stolen from bottles šŸ˜„) :

Bildschirmfoto vom 2024-01-18 15-56-26

I hope I do not become annoying by all these requests and PR's.
I liked to build a Distrobox UI like thing for quite some time now but never felt like doing so. But since this exists and I am now not alone I am super motivated.
Also it is written in Rust something I wanted to properly learn for quite some time too but except of some random more or less empty projects I never build much using Rust šŸ˜…

Dvlv commented 7 months ago

Hello. I have no problems with this in theory, but I think you'll run into this issue with the flatpak version: https://github.com/flatpak/xdg-desktop-portal/issues/475

See my comments here for more detail, and my current thoughts: https://github.com/Dvlv/BoxBuddyRS/issues/21#issuecomment-1898817934

I don't want the binary and flatpak versions to diverge, so I'd want this working in both versions.

I hope I do not become annoying by all these requests and PR's.

Not at all :smile:

Also it is written in Rust something I wanted to properly learn for quite some time too but except of some random more or less empty projects I never build much using Rust

Same for me, I mostly re-wrote this for a third time to practice Rust (and to get flathub distribution).

Dvlv commented 7 months ago

Think you're good to start working on this now, you have has_host_access in utils.rs to check if the user has access to the host filesystem.

VortexAcherontic commented 7 months ago

Many thanks will do!

Dvlv commented 7 months ago

Merged into master