Dwedit / PocketNES

NES emulator for GBA
49 stars 10 forks source link

initial mapper 30 support, tools and fixes for non-Windows builds #7

Open asiekierka opened 1 year ago

asiekierka commented 1 year ago

Based on https://github.com/FluBBaOfWard/NesDS/pull/1

Dwedit commented 1 year ago

Mapper 30 looks wrong. According to nesdev wiki, you get single screen mirroring with nametable selection when the 4 Screen flag is set, and the Vertical Mirroring flag is cleared. (Which is a bad design choice, as that is how you normally specify 4 screen mirroring!)

edit: Also the stack is imbalanced in that code and it will crash.