search

Dwolla / dwolla-v2-csharp

Official C# Wrapper for Dwolla's API
https://developers.dwolla.com
MIT License
12 stars 16 forks source link

Create Customer vs. Update Customer #4

Closed ithielnor closed 7 years ago

ithielnor commented 7 years ago

It looks like Update Customer accepts the same properties as Create Customer (at least for an unverified customer). Should there be a UpdateCustomerRequest model or should we just use the CreateCustomRequest. If the latter, I suggest renaming it.

therockstorm commented 7 years ago

It's actually two separate objects in our backend. We use Scala so for the Update, many of the fields are Option[String] vs String for Create. Additionally, Update can take a Status property for suspending or deactivating a customer. We use Swagger to auto-generate this page but the generated clients were pretty ugly. I started down the path to auto-generate at least the models from the Swagger JSON, but other things have come up.

therockstorm commented 7 years ago

I didn't realize CreateCustomerRequest already has Status, it shouldn't. I removed it and created an UpdateCustomerRequest