Bump target framework to netstandard2.0

Dwolla / dwolla-v2-csharp

Official C# Wrapper for Dwolla's API

https://developers.dwolla.com

MIT License

12 stars 15 forks source link

Bump target framework to netstandard2.0 #49

Closed IsaiahDahlberg closed 1 year ago

IsaiahDahlberg commented 1 year ago

Bump target framework to netstandard2.0
Replace Newtonsoft.Json with System.Text.Json
Setup static HttpClient in DwollaClient to follow MS guidance: HttpClient guidelines for .NET - .NET

natehitze commented 1 year ago

Hey @ShreyaThapa this is the first part of changes I mentioned to you in Slack back in December. This covers 1, 2, 4 (and addresses #41) from the list I sent you:

1- Bump target to at least netstandard2.0, possibly multitargeting if needed. Microsoft guidance says to avoid targeting netstandard1.x 2- Replace NewtonsoftJson with System.Text.Json 4- Replace static HttpClient

Please let Isaiah or I know if you or your team have any questions. Thanks!

ShreyaThapa commented 1 year ago

Awesome! Thanks for the PR submission, @natehitze and @IsaiahDahlberg!

We will prioritizing reviewing it during our upcoming sprint at the end of the month. Will keep you informed and let you know if we have any questions or feedback during the review process.

Cheers!

IsaiahDahlberg commented 1 year ago

@ShreyaThapa, should be good for another review!

natehitze commented 1 year ago

@ShreyaThapa Any idea on a timeline for review?