Extends internal HttpClient of Dwolla client

Dwolla / dwolla-v2-csharp

Official C# Wrapper for Dwolla's API

https://developers.dwolla.com

MIT License

12 stars 15 forks source link

Extends internal HttpClient of Dwolla client #53

Open DanielWilkowski-HammerPay opened 1 year ago

DanielWilkowski-HammerPay commented 1 year ago

Currently, the http client of Dwolla client is hermetic, and there is no way to access and/or extend it from the perspective of the users.

However we, for the purpose of development, would like to supply our custom http client implementation for the usage in dwolla sdk, for example to debug, log and intercept requests.

Currently, that's not possible because the interface of dwolla api is DwollaClient.create(isSandbox: true) and the constructor of DwollaClient is internal.

Do you think it would be possible to:

Either mark DwollaClient constructor as public
Expose interface to customize the internal http client used by dwolla sdk?

spencerhunter commented 1 year ago

Hi @DanielWilkowski-HammerPay , This is an interesting idea and something we've been considering supporting within the library. Would you want to configure the underlying HTTP library that's being used today or swap that out entirely for something different. If it's the former, could there be options that we could expose when instantiating the library?

DanielWilkowski-HammerPay commented 1 year ago

Hi @DanielWilkowski-HammerPay , This is an interesting idea and something we've been considering supporting within the library. Would you want to configure the underlying HTTP library that's being used today or swap that out entirely for something different. If it's the former, could there be options that we could expose when instantiating the library?

I can't speak for others, but me myself have 3 reasons to do this:

I would like to record exact raw http requests performed by dwolla sdk. currently, that can only be done from separate process via network sniffer. with custom http client, that could be done right from the source code
I would like to pass a fake http client in tests
In projects that already include an http client, I could write an adapter and pass to the dwolla sdk the client used by the application, instead of the one chosen by the sdk.