DyCI / dyci-main

Dynamic Code Injection Tool for Objective-C
MIT License
1.12k stars 121 forks source link

Carthage support #84

Closed olegam closed 9 years ago

olegam commented 9 years ago

Added support for adding dyci as a dependency using Carthage. Right now you can add dyci to your Cartfile using this line:

git "git@github.com:olegam/dyci-main.git" "master"
PaulTaykalo commented 9 years ago

Am Kind'a new for Carthage. Is it developer responsibilty to integrate library to his project after it will be downloaded by Carthage?

olegam commented 9 years ago

I highly recommend watching this talk by Justin Spahr-Summers: http://realm.io/news/swift-dependency-management-with-carthage/.

Carthage fetches the dependencies in a so-called Cartfile and builds a framework for each. The developer will manually drag the frameworks into his project once. But when the dependencies are updated the developer only needs to run carthage update.

PaulTaykalo commented 9 years ago

If so, then I thinkg the Project should be moved under
/Dynamic Code Injection/dyci-carthage
Since there already dyci-framework, dyci-example and others

olegam commented 9 years ago

The problem is that the project file must be in the root for Carthage to work. I know this is a little messy, but since I put Carthage in the name of the project file it should hopefully be less confusing what the file is for.

PaulTaykalo commented 9 years ago

Well, as i can see this one is seems to be working git "https://github.com/DyCI/dyci-main.git" "feature/carthage" https://github.com/DyCI/dyci-main/tree/feature/carthage/Dynamic%20Code%20Injection
@olegam Please confirm

olegam commented 9 years ago

Yes this works! I wonder how Carthage figures out to build the correct framework..

PaulTaykalo commented 9 years ago

@olegam As far as I found https://github.com/Carthage/Carthage/issues/210#issuecomment-67040112 it searchs the root-most :) project. So if there won't be radical structure changes, it should work

olegam commented 9 years ago

Great. Thanks!

PaulTaykalo commented 9 years ago

Thanks for the pull request :)