search

Dyalog / Jarvis

APL-based web service framework supporting JSON or REST
https://dyalog.github.io/Jarvis/
MIT License
33 stars 8 forks source link

Should we handle Cross-origin Request handling automatically? #3

Closed arcfide closed 4 years ago

arcfide commented 4 years ago

The current Jarvis doesn't appear to handle CORS situations when browsers access the data. Is there a clean and minimal way to do this in Jarvis itself that doesn't get too "over-engineered?"

arcfide commented 4 years ago

Looking into the code, it appears that Jarvis doesn't actually support any CORS handling for a JSON service, meaning that the service is inaccessible for a wide range of applications. I think it would be good to have CORS handling built-in.

arcfide commented 4 years ago

The current code in HandleRequest might be able to be retrofitted to rely on the application provided Validate function to handle the request. The only issue is that there is no way to signal to the system that the Validate has in fact Validated and completed the response. It's only a pass/fail.

We could split into a pass / response / fail mode, or we could leave the Validate function as a pass/fail and then have another function that handles CORS.

At the moment I'm inclined to just use the pass / response / fail model. I suggest that the return code will indicate this. If it is 0, then it is a passthrough. If it's positive, it's a fail and should follow the normal fail path. If it's a -1, then it should immediately send the response that was crafted by the validate function.

arcfide commented 4 years ago

c2940375f21e10b11ac3b026c05d99b870c3c107 adds support for CORS by default for JSON servers now.