search

Dyalog / ewc-client

Other
1 stars 4 forks source link

ids within a Grid a not unique - they should use the row to disambiguate #155

Closed mbaas2 closed 3 months ago

mbaas2 commented 7 months ago

for example: the checkbox in col Fixed has the same id F1.Holdings.CHECK in all 3 rows. I would suggest to build ids like F1.Holdings.r1.c2.CHECK (and F1.Holdings.r1.c2for the div corresponding to the cell).

NB: these ids are currently not required for testing - I am able to address cells using XPath - but it might help other users in their automation efforts.

NB: this was logged against the current version of the grid/cell-move branch running "DemoGrids"

mbaas2 commented 7 months ago

tested against updated branch "refactor/grid" - no longer a problem.

mbaas2 commented 5 months ago

It seems you recently started giving ids to rows as well. (row-1...) I like the idea, but I think these will need to be prefixed with the name of the table, as otherwise those ids will not be unique. (DemoGrids has 2 tables and so there are 2 elements with id="row-1".

mbaas2 commented 3 months ago

testing against the latest staging, I see this has been addressed.👍