search

Dyalog / ewc-client

Other
1 stars 4 forks source link

TabButtons do not have an id - it should match the one that's used with the WC-message #183

Closed mbaas2 closed 3 months ago

mbaas2 commented 5 months ago

see DemoRibbonTab2: the divs corresponding to the 3 tab buttons F1.TC.T1..3 do not have ids.

mqasim23 commented 4 months ago

please verify this on "staging" branch

mbaas2 commented 4 months ago

Thanks - this is beginning to work. But the current implementation creates duplicate ids when a ButtonGroup contains multiple elements (for example Application > Shares: "Denmark" and "Blue" both get id="F1.TC.SF3.Ribbon.Item4.GroupItem1.ButtonGroup1"

mqasim23 commented 4 months ago

Can you kindly verify now in staging branch, unique ids will be generated in buttonGroup

mbaas2 commented 3 months ago

Thanks - it works! 👍