During the review of PR #542, we agreed that a cleanup of the tests would be a good idea, when there is a bit more time. The list of questions to be asked and/or issues to be addressed is:
1) Why does QNDELETE call NDELETE and not ⎕NDELETE?
2) NDELETE and NPUT should probably go
3) QNMOVE definition in USE_MOCK_FSW case is very strange
4) Implement QNREPLACE & QNAPPEND and remove explicit calls to Notify
5) Why is Linktest.Fix in Notify
6) CleanFolders should prompty "Delete?" & 3 ⎕NDELETE
7) MOCK_OFF should be MOCK_ACTIVE
8) InitGlobals should use TESTNS
9) Replace ⎕SE.Link.Link.ns etc with a function GetLinks
10) Why is LinkCreate doing the Deserialise?
11) Put comment in LinkCreate to explain whassup
12) Notify needs a comment
13) Warning in Run about setting options is confusing
14) Remove dead code at end of Run
15) Is #.SLAVE needed in the non-isolate cases?
16) Remove the vestiges of pre-ISOLATE code
17) Remove ⎕IO from SetupSlave
18) Remove ⍺←⊢ from QNPUT
19) Recheck why NPUT was moved before clearing the log in test for issue #235
During the review of PR #542, we agreed that a cleanup of the tests would be a good idea, when there is a bit more time. The list of questions to be asked and/or issues to be addressed is:
1) Why does QNDELETE call NDELETE and not ⎕NDELETE? 2) NDELETE and NPUT should probably go 3) QNMOVE definition in USE_MOCK_FSW case is very strange 4) Implement QNREPLACE & QNAPPEND and remove explicit calls to Notify 5) Why is Linktest.Fix in Notify 6) CleanFolders should prompty "Delete?" & 3 ⎕NDELETE 7) MOCK_OFF should be MOCK_ACTIVE 8) InitGlobals should use TESTNS 9) Replace ⎕SE.Link.Link.ns etc with a function GetLinks 10) Why is LinkCreate doing the Deserialise? 11) Put comment in LinkCreate to explain whassup 12) Notify needs a comment 13) Warning in Run about setting options is confusing 14) Remove dead code at end of Run 15) Is #.SLAVE needed in the non-isolate cases? 16) Remove the vestiges of pre-ISOLATE code 17) Remove ⎕IO from SetupSlave 18) Remove ⍺←⊢ from QNPUT 19) Recheck why NPUT was moved before clearing the log in test for issue #235