Dyalog / link

Source code for Link – the built-in component that enables the use of text files as the primary storage mechanism for APL source code
https://dyalog.github.io/link
MIT License
19 stars 12 forks source link

Better Create failure msgs #615

Closed abrudz closed 8 months ago

abrudz commented 9 months ago

The error message "Destination directory not empty" from Create should be something like "Destination directory neither empty nor matching namespace"

aplteam commented 9 months ago

I find the proposed error message confusing, but maybe that's just me.

On Mon, 18 Dec 2023 at 11:27, Adám Brudzewsky @.***> wrote:

The error message "Destination directory not empty" from Create should be something like "Destination directory neither empty nor matching namespace"

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

abrudz commented 9 months ago

@aplteam The issue is that "Destination directory not empty" is misleading when trying to re-establish the connection between a namespace and a directory, but differences have crept in. (If everything matches, Link will happily establish a connection, though both sides have contents.) Do you have a suggestion for a better general message? (Link cannot distinguish between the case where you're trying to link to an already used directory, and the case where there's a discrepancy in an otherwise sync'ed ns–dir pair.)

aplteam commented 9 months ago

Destination directory is not empty and does not match the specified namespace.