search

Dyalog / ride

Cross-platform IDE for Dyalog APL
https://dyalog.github.io/ride
MIT License
202 stars 31 forks source link

Make edit msgbox error message more user friendly, e.g. by removing it altogether #109

Closed dyaandys closed 1 year ago

dyaandys commented 7 years ago

z←(⎕Wa-100000)⍴2 z ED

Msgbox appears with "An error (1) occurred processing Edit"

How about "Error: WS FULL generated by the Editor" (approved by docs mgr)

IDE: Version: 4.0.2679 Platform: MacIntel Date: 2017-03-01 19:10:37 +0000 Git commit: c359f660447dce9b29195939a3a6a052af6cedac Preferences:{

}

Interpreter: Version: 16.0.29355 Platform: Mac-64 Edition: Unicode/64 Date: Mar 2 2017 at 02:32:24

e9gille commented 7 years ago

@johndaintree This currently reports the undocumented InternalError with an object: { "error": 1, "dmx": 0 "message": "Edit" }

Do you want to include more detail for us to show or add something to the protocol to request/map from error number to description?

johndaintree commented 7 years ago

I can include the ⎕EM of the error number (in this case 1 == WS FULL) if that would help you. Pretty much all I have to give is ⎕EN (and ⎕EM), ⎕DMX.Message and the protocol message that lead to the error.

/JD

From: Gilgamesh Athoraya [mailto:notifications@github.com] Sent: 03 March 2017 11:01 To: Dyalog/ride ride@noreply.github.com Cc: johndaintree johnd@dyalog.com; Mention mention@noreply.github.com Subject: Re: [Dyalog/ride] Make edit msgbox error message more user friendly (#109)

@johndaintree https://github.com/johndaintree This currently reports the undocumented InternalError with an object: { "error": 1, "dmx": 0 "message": "Edit" }

Do you want to include more detail for us to show or add something to the protocol to request/map from error number to description?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Dyalog/ride/issues/109#issuecomment-283926556 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKU_CRexBm0qqtx0eFPfn2JXSKAhUmpAks5rh_MFgaJpZM4MQ5rP . https://github.com/notifications/beacon/AKU_Cantfpl9uXX5j9COPfAYwFJOz96oks5rh_MFgaJpZM4MQ5rP.gif

e9gille commented 7 years ago

@johndaintree That should be plenty. @dyaandys Are you happy with that? I don't think RIDE should have a dictionary of error messages for these errors, what JD is offering is probably enough.

dyaandys commented 7 years ago

OK .. @FionaDyalog and I have had a chat with JD: we're more than happy with "WS FULL" rather than "(1)", but we really would like something better than "processing Edit". I think we need to have a think and a discussion about this .. we may need to have a dictionary of messages for the different message types, but not for the APL errors.

abrudz commented 1 year ago

WinIDE doesn't pop up a message, it just prints WS FULL in the session (19.0: in error colour). RIDE could do the same.

Btw, ⎕ED'z' gives a normal WS FULL ERROR on ⎕ED and )ed z gives WS FULL ERROR. There's no reason Shift+Enter or double-clicking should be any different.

e9gille commented 1 year ago

RIDE can't add text to the session log itself as it would cause the logs to get out of sync. I see that the message now includes the property error_text that has a more descriptive message, so will use that instead for now. If you want the message written to session the interpreter should be changed to send an AppendSessionOutput rather than InternalError