search

Dyalog / ride

Cross-platform IDE for Dyalog APL
https://dyalog.github.io/ride
MIT License
203 stars 31 forks source link

Adress os-locale 6.0.0 breaking change #1112

Closed TomaSajt closed 1 year ago

TomaSajt commented 1 year ago

Describe the issue you are having

The os-locale dependency has been updated in a recent commit from 5.0.0 to 6.0.2.

However there was a breaking change between major versions, which was that os-locale became a pure ESM package.

Changelog of os-locale 6.0.0 The package owner's proposed solutions for using the package with Electron

I did not notice this change, because of my saved preferences (in prefs.js the kbdLocale field), however, once I deleted my RIDE config directory, (or just the prefs file,) it couldn't start the interpreter, because of errors being thrown about not being able to require(...) ESM modules.

I think it is acceptable to revert the version of os-locale to 5.0.0

e9gille commented 1 year ago

well spotted, will downgrade as suggested