Dyalog / ride

Cross-platform IDE for Dyalog APL
https://dyalog.github.io/ride
MIT License
198 stars 29 forks source link

Consider bumping @electron/remote version to support later electron versions #1233

Closed TomaSajt closed 1 month ago

TomaSajt commented 1 month ago

I maintain the Ride package in Nixpkgs, and since electron <=28 is EOL I'm trying to use a later electron version. However, using a later electron version leads to the following error (when run with --enable-logging):

[198292:0612/113921.722456:INFO:CONSOLE(271)] "Uncaught TypeError: Cannot read properties of undefined (reading 'require')", source: /home/toma/projects/nixpkgs/ride/node_modules/@electron/remote/dist/src/renderer/remote.js (271)
[198292:0612/113921.921965:INFO:CONSOLE(145)] "Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'config')", source: file:///home/toma/projects/nixpkgs/ride/src/ipc.js (145)

After updating @electron/remote to the latest version, this error goes away and everything works fine. Until this is addressed here, on the upstream, I'll be patching to source to fix this.

This is probably the update that fixed it: https://github.com/electron/remote/releases/tag/v2.1.1

Related Nixpkgs PR: https://github.com/NixOS/nixpkgs/pull/319284