search

Dyalog / ride

Cross-platform IDE for Dyalog APL
https://dyalog.github.io/ride
MIT License
206 stars 32 forks source link

Fix autocomplete suggestions #1241

Closed Lindeneg closed 4 months ago

Lindeneg commented 4 months ago

A take on issue #753

These autocomplete suggestions were already in code but they were hidden behind an if block and were only shown, if the previous token was class or namespace but the latter had a typo.

So I fixed the typo and also ensured that :Property only shows within a :Class and :Interface definitions.

Lastly, :Section is available as a default suggestion, if I read the documentation correct here (p.104), :Section are for readability and are allowed within both function and class definitions.

Please forgive me if I did something stupid, I'd be more than happy to accommodate feedback.

abrudz commented 4 months ago

A property can also appear within an interface. This is valid:

:Interface i
    :Property var
        ∇ r←get
        ∇
        ∇ set args
        ∇
    :EndProperty
:EndInterface
e9gille commented 4 months ago

A property can also appear within an interface. This is valid:

:Interface i
    :Property var
        ∇ r←get
        ∇
        ∇ set args
        ∇
    :EndProperty
:EndInterface

ah, that I had overlooked, thanks.

Lindeneg commented 4 months ago

Thanks @abrudz and @e9gille. :Property is now suggested within both a :Class and :Interface definition