Closed jayfoad closed 6 years ago
@ngn I'm tempted to fix this by removing RIDE's custom "simple" scrollbars, and going back to the default "native" style. They look roughly the same (on Windows and Linux at least) but work better. Do you think this would cause problems? Why did you implement custom scrollbars in the first place (54a4db210c5aa32a20d5d65f273907efa87c567f)?
two reasons:
the name "simple" is inherited from https://github.com/codemirror/CodeMirror/blob/master/addon/scroll/simplescrollbars.js which I used as a starting point
to allow for virtual whitespace at the bottom of the session so the Dyalog banner can appear on top
Even if I go back to "native" scrollbars I can still scroll (with the mouse wheel) down into virtual whitespace, so that my cursor is at the top of the screen.
I can still scroll (with the mouse wheel) down into virtual whitespace, so that my cursor is at the top of the screen.
When I remember, I do that to move the banner to the top of the screen before plugging in the projector for a demo.
Even if I go back to "native" scrollbars I can still scroll (with the mouse wheel) down into virtual whitespace
As long as the initial banner placement is correct, I think scrapping my custom scrollbars would be the right thing to do. I guess Mac users wouldn't mind Apple's native invisible scrollbars too much.
Commit d2f240f nullified code we wrote to ensure the session placement was correct when doing things such as opening the workspace explorer. The switch to native scrollbars will be reverted in the next commit.
When you click the arrow at either end of a RIDE scrollbar (down the side of the session or an editor) it seems to scroll by a full page, instead of just a line. And if you hold the mouse button down then nothing happens until you release it; it would be nice if it auto-repeated, scrolling a line at a time until you release the button.